Move statements before super(..) in Java constructor #733

[rkampani]

What's changed?

• Relates tohttps://github.com/Move statements before super(..) in Java constructor #733
  Jep 513 calls for allowing statements before the call to super() in Java constructors, allowing for simple assignments and validations before doing expensive construction.

Java version >= 25
(Also double check Jep 513 lands in Java 25)

Before Applying Recipe

class A {
    public A(String bar) {
        super();
        if(bar.equals("test"))
            throw new RuntimeException();
    }
}

After Applying Recipe

class A {
    public A(String bar) {
        if(bar.equals("test"))
            throw new RuntimeException();
        super();
    }
}

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

• depends on Add parser for Java 25 rewrite#5717 (comment)

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[github-actions]

Some suggestions could not be made:

• src/main/resources/META-INF/rewrite/examples.yml
  • lines 997-1007
  • lines 1036-1042
  • lines 7108-7107

[github-actions]

Some suggestions could not be made:

• src/main/resources/META-INF/rewrite/examples.yml
  • lines 997-1007
  • lines 1036-1042
  • lines 7108-7107

[timtebeek]

We're seeing some unrelated test failures; no need for alarm or debugging; we'll try to get those sorted soon. :)

[github-actions]

Some suggestions could not be made:

• src/main/resources/META-INF/rewrite/examples.yml
  • lines 701-700
  • lines 997-1007
  • lines 1036-1042

[MBoegers]

Thanks for your contribution, I love seeing new Language features been picked up :) I think 1 or 2 tests should be enough to make sure we are JLS compliant in the context of the Early construction contexts.

[timtebeek]

We've just merged the Java 25 parser support, so we can have another look here now. Would you want to continue this work @rkampani , or would you like us to take over?

• Init of Java 25 parser rewrite#5985

[rkampani]

#736 (comment)
@timtebeek Thank you for the reminder — I had completely forgotten about it. I've just pushed the changes. Could you please re-review when you get a chance

[tfeuerba]

Isn't this changing semantics? Supplying -4 will now raise "Age must be between 18 and 67" instead of "Age cannot be negative".