pass constants FUNCTIONS_SRC and PUBLISH_DIR to nextOnNetlify #49
Conversation
lindsaylevine
added
the
type: feature
lindsaylevine
force-pushed
the
ll/use-configurable-dirs
branch
from
5a23158 to
981d538
Compare
|
there's a "blocking" issue with this currently:
possible solutions:
|
package.json
Outdated
| "homepage": "https://github.com/netlify/netlify-plugin-nextjs#readme", | ||
| "dependencies": { | ||
| "chalk": "^4.1.0", | ||
| "cpx": "^1.5.0", |
| expect(await pathExists(PUBLISH_DIR)).toBeTruthy() | ||
| const nextOnNetlifyOptions = nextOnNetlify.mock.calls[0][0] | ||
| expect(nextOnNetlifyOptions.functionsDir).toEqual(FUNCTIONS_SRC) | ||
| expect(nextOnNetlifyOptions.publishDir).toEqual(PUBLISH_DIR) |
There was a problem hiding this comment.
Sounds good 👍
Should we call the "real" next-on-netlify instead of mocking it? This would give a stronger confidence that the files are actually being copied to those directories. Generally speaking, this would be a stronger indicator that the plugin works as intended. What do you think? (Note: this would probably be better done in a separate PR)
There was a problem hiding this comment.
yes, definitely. when i tried to call the "real" nextOnNetlify at first, i got errors due to the emptyDirSync stuff in the prev NoN version. now we can address this in a separate PR. here's an issue #53 :)
There was a problem hiding this comment.
Thanks for opening an issue for it! ❤️
There was a problem hiding this comment.
Your solution 2. sounds good 👍 (as fixed in netlify/next-on-netlify#94)
I think this applies to the Functions directory too. If the user already has some Functions in their site, we don't want to remove them :)
lindsaylevine
force-pushed
the
ll/use-configurable-dirs
branch
from
981d538 to
c71248d
Compare
* Update actions * Run tests if labeled * Add NEXT_TEST_JOB * ignore scripts for faster install * Show test results in summary and fail action if errors
2 participants
Fixes #43
wasn't quite sure how to replace the tests now that the manual copying is no longer a part of the plugin. making a note to add a specific test for this in next-on-netlify.