Skip to content

feat: support for basePath #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2021
Merged

feat: support for basePath #374

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0fb79c
feat: support for basePath
lindsaylevine May 29, 2021
906d9f6
chore: cleanup, catch-all, cypress tests pass
lindsaylevine Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/cypress/fixtures/next.config.js-with-basePath
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module.exports = {
target: "experimental-serverless-trace",
basePath: "/foo",
};
2 changes: 1 addition & 1 deletion src/cypress/fixtures/pages/getServerSideProps/[id].js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const Show = ({ errorCode, show }) => {
return (
<div>
<p>
This page uses getInitialProps() to fetch the show with the ID provided in the URL: /shows/:id
This page uses getServerSideProps() to fetch the show with the ID provided in the URL: /shows/:id
<br />
Refresh the page to see server-side rendering in action.
<br />
Expand Down
2 changes: 1 addition & 1 deletion src/cypress/fixtures/pages/getServerSideProps/static.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import Link from 'next/link'
const Show = ({ show }) => (
<div>
<p>
This page uses getInitialProps() to fetch the show with the ID provided in the URL: /shows/:id
This page uses getServerSideProps() to fetch the show with the ID provided in the URL: /shows/:id
<br />
Refresh the page to see server-side rendering in action.
<br />
Expand Down
Loading