Skip to content

Conversation

@ppinard
Copy link
Member

@ppinard ppinard commented Mar 17, 2019

Use dataclass for descriptor and properties

@codecov-io
Copy link

Codecov Report

Merging #14 into master will increase coverage by 9.11%.
The diff coverage is 99.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   84.13%   93.24%   +9.11%     
==========================================
  Files          18       34      +16     
  Lines        2779     3466     +687     
==========================================
+ Hits         2338     3232     +894     
+ Misses        441      234     -207
Impacted Files Coverage Δ
pyxray/cbook.py 100% <ø> (ø) ⬆️
pyxray/property.py 96.36% <100%> (+0.97%) ⬆️
pyxray/descriptor.py 82.27% <100%> (+7.27%) ⬆️
pyxray/test_cbook.py 100% <100%> (ø)
pyxray/test_descriptor.py 100% <100%> (ø)
pyxray/test_property.py 88.23% <85.71%> (ø)
pyxray/_version.py
pyxray/parser/test_campbell2001.py 100% <0%> (ø)
pyxray/parser/test_unattributed.py 100% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ca07d3...e639ea3. Read the comment docs.

@ppinard ppinard merged commit 499b1a6 into master Mar 17, 2019
@ppinard ppinard deleted the dataclass branch March 17, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants