Skip to content

Conversation

@ktakakuri
Copy link
Member

@ktakakuri ktakakuri commented Nov 6, 2025

This fix updates the hotspot build script to recognize the latest version of VS2022. The fix is similar to: #412.
I confirmed that the build succeeds using Visual Studio 2022 17.14 with this fix.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8371387 needs maintainer approval

Issue

  • JDK-8371387: [8u] hotspot needs to recognise latest VS2022 (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/714/head:pull/714
$ git checkout pull/714

Update a local copy of the PR:
$ git checkout pull/714
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/714/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 714

View PR using the GUI difftool:
$ git pr show -t 714

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/714.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2025

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 6, 2025

⚠️ @ktakakuri This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@ktakakuri
Copy link
Member Author

/approval request The patch updates hotspot build scripts to recognize cl.exe versions 1939 through 1944 and link.exe versions 1439 through 1444 belonging to the MSVS2022 family.

@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@ktakakuri
8371387: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 7, 2025
@ktakakuri
Copy link
Member Author

@gnu-andrew I apologize for bothering you during your busy schedule, but could you please review the Fix Request? I would like to include this fix in the January release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants