-
Notifications
You must be signed in to change notification settings - Fork 173
8371334: [8u] GHA: installation of VS2010 hangs #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
|
@zzambers This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Follow-up PR with fixes of build errors on VS2010: #713 |
gnu-andrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks for fixing this. I had seen the failures on recent PRs, but just thought it was a temporary outage.
|
|
|
@zzambers Please apply for approval to make progress on the GHA issues. Thanks! |
|
/approval request Fix for VS2010 installation in GHA, low risk - only affects testing in GHA, testing OK |
|
/approve yes |
|
@jerboaa |
|
/integrate |
|
Going to push as commit a8cf6db. |
Installation of VS2010 hangs. As result Windows x86 (32-bit) jobs in GitHub CI timeout and get cancelled.
After some debugging, it turns out, that issue is caused by missing PowerShell 2, required by VS2010 installer. See screenshot:

PowerShell 2.0 was deprecated and recently stopped being shipped by on windows. Microsoft says following on their page:
Fortunately they still provide archive to install it manually. This PR does that.
Testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/712/head:pull/712$ git checkout pull/712Update a local copy of the PR:
$ git checkout pull/712$ git pull https://git.openjdk.org/jdk8u-dev.git pull/712/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 712View PR using the GUI difftool:
$ git pr show -t 712Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/712.diff
Using Webrev
Link to Webrev Comment