Skip to content

Conversation

@zzambers
Copy link
Contributor

@zzambers zzambers commented Nov 5, 2025

Installation of VS2010 hangs. As result Windows x86 (32-bit) jobs in GitHub CI timeout and get cancelled.

After some debugging, it turns out, that issue is caused by missing PowerShell 2, required by VS2010 installer. See screenshot:
screen-10

PowerShell 2.0 was deprecated and recently stopped being shipped by on windows. Microsoft says following on their page:

PowerShell 2.0 will be removed in a later release starting in August 2025 for Windows 11, version 24H2 and a September 2025 release for Windows Server 2025. All later releases for Windows 11 and Windows Server 2025 will not include PowerShell 2.0.

Fortunately they still provide archive to install it manually. This PR does that.

Testing:

  • build still fails on windows x86 due to recent changes to jdk 8 code. It can be fixed in followup PR.
  • MacOS build job got canceled because MacOS 13 is deprecated in GHA (this is separate issue not related to this)
  • security infra failures are unrelated

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8371334 needs maintainer approval

Issue

  • JDK-8371334: [8u] GHA: installation of VS2010 hangs (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/712/head:pull/712
$ git checkout pull/712

Update a local copy of the PR:
$ git checkout pull/712
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/712/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 712

View PR using the GUI difftool:
$ git pr show -t 712

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/712.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2025

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8371334: [8u] GHA: installation of VS2010 hangs

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 5, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 5, 2025

Webrevs

@zzambers
Copy link
Contributor Author

zzambers commented Nov 5, 2025

Follow-up PR with fixes of build errors on VS2010: #713

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for fixing this. I had seen the failures on recent PRs, but just thought it was a temporary outage.

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@jerboaa
Copy link
Contributor

jerboaa commented Nov 11, 2025

@zzambers Please apply for approval to make progress on the GHA issues. Thanks!

@zzambers
Copy link
Contributor Author

/approval request Fix for VS2010 installation in GHA, low risk - only affects testing in GHA, testing OK

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

@zzambers
8371334: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 11, 2025
@jerboaa
Copy link
Contributor

jerboaa commented Nov 11, 2025

/approve yes

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

@jerboaa
8371334: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 11, 2025
@zzambers
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

Going to push as commit a8cf6db.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 11, 2025
@openjdk openjdk bot closed this Nov 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 11, 2025
@openjdk
Copy link

openjdk bot commented Nov 11, 2025

@zzambers Pushed as commit a8cf6db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants