Skip to content

Conversation

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Sep 8, 2025

Trivial patch to problem list a test we know fails. This should reduce test noise.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8367115 needs maintainer approval

Issue

  • JDK-8367115: [8u] Problem list CAInterop.java#actalisauthenticationrootca test (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/695/head:pull/695
$ git checkout pull/695

Update a local copy of the PR:
$ git checkout pull/695
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/695/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 695

View PR using the GUI difftool:
$ git pr show -t 695

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/695.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2025

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 8, 2025

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8367115: [8u] Problem list CAInterop.java#actalisauthenticationrootca test

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 9a1f0c6: 8364597: Replace THL A29 Limited with Tencent
  • 2b36fc1: 8345358: Some DLL Files are missing Windows Properties

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@jerboaa
Copy link
Contributor Author

jerboaa commented Sep 9, 2025

Remaining failures are the intermittent CAInterop.java#entrustrootcag4 failures.

@jerboaa jerboaa marked this pull request as ready for review September 9, 2025 12:33
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 9, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 9, 2025

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented Sep 9, 2025

Remaining failures are the intermittent CAInterop.java#entrustrootcag4 failures.

Filed https://bugs.openjdk.org/browse/JDK-8367256 for this.

@jerboaa
Copy link
Contributor Author

jerboaa commented Sep 9, 2025

#696 depends on this and then GHA is green.

@jerboaa jerboaa mentioned this pull request Sep 9, 2025
5 tasks
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Please apply for approval.

@openjdk
Copy link

openjdk bot commented Sep 17, 2025

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@jerboaa
Copy link
Contributor Author

jerboaa commented Sep 17, 2025

/approval request Please approve this 8u-specific problem listing since it causes issues in GHA for everyone where we run those tests and fail. Risk is low as it's problem-listing an already known-to-fail test. We'll delist once the underlying issue is fixed.

@openjdk
Copy link

openjdk bot commented Sep 17, 2025

@jerboaa
8367115: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 17, 2025
@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 17, 2025

@gnu-andrew
8367115: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 17, 2025
@jerboaa
Copy link
Contributor Author

jerboaa commented Sep 17, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Sep 17, 2025

Going to push as commit 9948bd6.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 9a1f0c6: 8364597: Replace THL A29 Limited with Tencent
  • 2b36fc1: 8345358: Some DLL Files are missing Windows Properties

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 17, 2025
@openjdk openjdk bot closed this Sep 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 17, 2025
@openjdk
Copy link

openjdk bot commented Sep 17, 2025

@jerboaa Pushed as commit 9948bd6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants