-
Notifications
You must be signed in to change notification settings - Fork 173
8367115: [8u] Problem list CAInterop.java#actalisauthenticationrootca test #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
|
@jerboaa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Remaining failures are the intermittent |
Filed https://bugs.openjdk.org/browse/JDK-8367256 for this. |
|
#696 depends on this and then GHA is green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Please apply for approval.
|
|
|
/approval request Please approve this 8u-specific problem listing since it causes issues in GHA for everyone where we run those tests and fail. Risk is low as it's problem-listing an already known-to-fail test. We'll delist once the underlying issue is fixed. |
|
/approve yes |
|
@gnu-andrew |
|
/integrate |
Trivial patch to problem list a test we know fails. This should reduce test noise.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/695/head:pull/695$ git checkout pull/695Update a local copy of the PR:
$ git checkout pull/695$ git pull https://git.openjdk.org/jdk8u-dev.git pull/695/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 695View PR using the GUI difftool:
$ git pr show -t 695Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/695.diff
Using Webrev
Link to Webrev Comment