-
Notifications
You must be signed in to change notification settings - Fork 173
8338144: [8u] Remove duplicate license files #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
|
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
|
|
Thanks for the review, @phohensee |
|
@gnu-andrew |
|
/approve yes |
|
@jerboaa |
|
Thanks @jerboaa |
|
Going to push as commit ea76f37.
Your commit was automatically rebased without conflicts. |
|
@gnu-andrew Pushed as commit ea76f37. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This removes the duplicate copies of the three licensing files -
LICENSE,ASSEMBLY_EXCEPTIONandTHIRD_PARTY_README- from the top of each of the old subrepositories -corba,jaxp,jaxws,langtools,jdk,hotspotandnashorn. TheImages.gmkmakefile under thejdktree has to be updated to use the top-level versions rather than thejdkones.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/557/head:pull/557$ git checkout pull/557Update a local copy of the PR:
$ git checkout pull/557$ git pull https://git.openjdk.org/jdk8u-dev.git pull/557/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 557View PR using the GUI difftool:
$ git pr show -t 557Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/557.diff
Webrev
Link to Webrev Comment