Skip to content

Conversation

@archiecobbs
Copy link
Contributor

@archiecobbs archiecobbs commented Jun 27, 2025

Hi all,

This pull request contains a backport of commit 3525a40f from the openjdk/jdk repository.

The commit being backported was authored by Archie Cobbs on 27 Jun 2025 and was reviewed by Maurizio Cimadamore and Uwe Schindler.

There is an associated CSR which has already been approved: JDK-8359844

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8359844 to be approved
  • JDK-8359596 needs maintainer approval

Issues

  • JDK-8359596: Behavior change when both -Xlint:options and -Xlint:-options flags are given (Bug - P2 - Approved)
  • JDK-8359844: Behavior change when both -Xlint:options and -Xlint:-options flags are given (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/8/head:pull/8
$ git checkout pull/8

Update a local copy of the PR:
$ git checkout pull/8
$ git pull https://git.openjdk.org/jdk25u.git pull/8/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8

View PR using the GUI difftool:
$ git pr show -t 8

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/8.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2025

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 27, 2025

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359596: Behavior change when both -Xlint:options and -Xlint:-options flags are given

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 3525a40f39a966b8592f694a9b3cd4c5dc449266 8359596: Behavior change when both -Xlint:options and -Xlint:-options flags are given Jun 27, 2025
@openjdk
Copy link

openjdk bot commented Jun 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 27, 2025
@openjdk
Copy link

openjdk bot commented Jun 27, 2025

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jun 27, 2025
@archiecobbs
Copy link
Contributor Author

/touch

@openjdk
Copy link

openjdk bot commented Jun 27, 2025

@archiecobbs The pull request is being re-evaluated and the inactivity timeout has been reset.

@openjdk
Copy link

openjdk bot commented Jun 27, 2025

⚠️ @archiecobbs This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link

mlbridge bot commented Jun 27, 2025

Webrevs

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jun 27, 2025
@archiecobbs
Copy link
Contributor Author

/approval request Please see the CSR for motivation and reasoning.

@openjdk
Copy link

openjdk bot commented Jun 27, 2025

@archiecobbs
8359596: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 27, 2025
@archiecobbs
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 30, 2025
@openjdk
Copy link

openjdk bot commented Jun 30, 2025

@archiecobbs
Your change (at version 988eaaa) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 30, 2025

Going to push as commit 16addb1.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 30, 2025
@openjdk openjdk bot closed this Jun 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 30, 2025
@openjdk
Copy link

openjdk bot commented Jun 30, 2025

@phohensee @archiecobbs Pushed as commit 16addb1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants