Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 13, 2025

Hi all,

This pull request contains a backport of commit 56a27d11 from the openjdk/jdk repository.

The commit being backported was authored by Daniel Lundén on 12 Nov 2025 and was reviewed by Roberto Castañeda Lozano and Damon Fenacci.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8341039 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8341039: compiler/cha/TypeProfileFinalMethod.java fails with assertEquals expected: 0 but was: 2 (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/376/head:pull/376
$ git checkout pull/376

Update a local copy of the PR:
$ git checkout pull/376
$ git pull https://git.openjdk.org/jdk25u.git pull/376/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 376

View PR using the GUI difftool:
$ git pr show -t 376

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/376.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 56a27d11971d935e8b28ac9d701cf9890014a949 8341039: compiler/cha/TypeProfileFinalMethod.java fails with assertEquals expected: 0 but was: 2 Nov 13, 2025
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 13, 2025
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025
@sendaoYan
Copy link
Member Author

Run test test/hotspot/jtreg/compiler/cha/TypeProfileFinalMethod.java with default jvm option and -Xcomp option on linux-x64, test run passed.

@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

@sendaoYan
Copy link
Member Author

GHA report serviceability/jvmti/RedefineClasses/ClassVersionAfterRedefine.java fails on linux-64. This failure has been recorded by CODETOOLS-7904109.

I think it's unrelated to this backport PR.

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the test bug which may cause test fails with -Xcomp option. Change has been verified locally by run test test/hotspot/jtreg/compiler/cha/TypeProfileFinalMethod.java with default jvm option and -Xcomp option on linux-x64. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Nov 17, 2025

@sendaoYan
8341039: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant