-
Notifications
You must be signed in to change notification settings - Fork 232
8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main #4164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
|
@satyenme This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle. Risk: Low. Ran GHA Sanity Checks and adjusted manual test. Patch is clean. Change has been present in tip since March, 2024, change has been accepted by Oracle (and tests were previously closed source). |
Backporting JDK-8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main. Converts bug6524424 from old applet format to more modern main function approach. Ran GHA Sanity Checks and adjusted test directly. Patch is clean. Backporting for parity with Oracle.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4164/head:pull/4164$ git checkout pull/4164Update a local copy of the PR:
$ git checkout pull/4164$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4164/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4164View PR using the GUI difftool:
$ git pr show -t 4164Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4164.diff
Using Webrev
Link to Webrev Comment