Skip to content

Conversation

@satyenme
Copy link

@satyenme satyenme commented Nov 10, 2025

Backporting JDK-8327856: Convert applet test SpanishDiacriticsTest.java to a main program. Converts SpanishDiacriticsTest from old applet format to more modern main function approach. Ran GHA Sanity Checks and adjusted test directly. Patch is clean. Backporting for parity with Oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8327856 needs maintainer approval

Issue

  • JDK-8327856: Convert applet test SpanishDiacriticsTest.java to a main program (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4163/head:pull/4163
$ git checkout pull/4163

Update a local copy of the PR:
$ git checkout pull/4163
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4163

View PR using the GUI difftool:
$ git pr show -t 4163

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4163.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327856: Convert applet test SpanishDiacriticsTest.java to a main program

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e3c50e1: 8358764: (sc) SocketChannel.close when thread blocked in read causes connection to be reset (win)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 22f10e045b3decdb51a3cc7644c47f911aec753d 8327856: Convert applet test SpanishDiacriticsTest.java to a main program Nov 10, 2025
@openjdk
Copy link

openjdk bot commented Nov 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 10, 2025
@openjdk
Copy link

openjdk bot commented Nov 10, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 10, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2025

Webrevs

@satyenme
Copy link
Author

/approval request for backport of JDK-8327856: Convert applet test SpanishDiacriticsTest.java to a main program

Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle.

Risk: Low. Ran GHA Sanity Checks and adjusted manual test. Patch is clean. Change has been present in tip since March, 2024, change has been accepted by Oracle (and tests were previously closed source).

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@satyenme
8327856: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant