8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run

[VladimirKempik]

Please review this backport. Not applying clean. A follow up patch for jep-391 backport

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run

Reviewers

• Anton Kozlov (@AntonKozlov - no project role) ⚠️ Review applies to e175c0e
• Andrew Dinn (@adinn - Reviewer) ⚠️ Review applies to e175c0e
• Bernhard Urban-Forster (@lewurm - no project role) ⚠️ Review applies to e175c0e

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/817/head:pull/817
$ git checkout pull/817

Update a local copy of the PR:
$ git checkout pull/817
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/817/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 817

View PR using the GUI difftool:
$ git pr show -t 817

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/817.diff

[bridgekeeper]

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into pr/715 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full (7a0f9eda)
• 01: Full - Incremental (e175c0e9)
• 00: Full (f6c86be7)

[AntonKozlov]

Looks good. It's probably possible to move W^X flip under thread->is_Java_thread() condition, but the current code is safer.

[adinn]

Looks good

[openjdk-notifier]

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8253795
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run

Reviewed-by: akozlov, adinn, burban

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

⚠️ @VladimirKempik This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[VladimirKempik]

/integrate

[openjdk]

Going to push as commit 69583df.
Since your change was applied there has been 1 commit pushed to the master branch:

• aa42c4d: 8241004: NMT tests fail on unaligned thread size with debug build

Your commit was automatically rebased without conflicts.

[openjdk]

@VladimirKempik Pushed as commit 69583df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.