-
Notifications
You must be signed in to change notification settings - Fork 253
8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8262896: [macos_aarch64] Crash in jni_fast_GetLongField
Co-authored-by: Mikael Vidstedt <[email protected]> Reviewed-by: dholmes, gziemski
|
👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
adinn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8253795
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
@VladimirKempik This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
|
|
/integrate |
|
Going to push as commit 0aa5f75.
Your commit was automatically rebased without conflicts. |
|
@VladimirKempik Pushed as commit 0aa5f75. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Pleas review this backport to jdk11u-dev.
It's one of few follow up fixes for jep-391 backport.
This adds missing WX transition to jni_DestroyJavaVM_inner and jni_DetachCurrentThread
Not applying clean due to context code difference in chunk 2.
In JDK17 it's - ThreadStateTransition::transition()
in JDK11 it's - ThreadStateTransition::transition_and_fence()
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/816/head:pull/816$ git checkout pull/816Update a local copy of the PR:
$ git checkout pull/816$ git pull https://git.openjdk.java.net/jdk11u-dev pull/816/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 816View PR using the GUI difftool:
$ git pr show -t 816Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/816.diff