Skip to content

Conversation

@tstuefe
Copy link
Member

@tstuefe tstuefe commented Jun 30, 2021

Hi all,

this pull request contains a backport of commit 1740de2 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Stuefe on 11 Feb 2021 and was reviewed by Zhengyu Gu.

Patch applies cleanly.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/80/head:pull/80
$ git checkout pull/80

Update a local copy of the PR:
$ git checkout pull/80
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/80/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 80

View PR using the GUI difftool:
$ git pr show -t 80

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/80.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2021

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1740de2a0d41d0689ae9bb069b93ab267a2b9495 8261297: NMT: Final report should use scale 1 Jun 30, 2021
@openjdk
Copy link

openjdk bot commented Jun 30, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 30, 2021
@openjdk
Copy link

openjdk bot commented Jun 30, 2021

@tstuefe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261297: NMT: Final report should use scale 1

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

  • fdaa4f0: 8255810: Zero: build fails without JVMTI
  • 3f03476: 8224853: CDS address sanitizer errors
  • 65b215a: 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test
  • c61cfb5: 8255718: Zero: VM should know it runs in interpreter-only mode
  • 3e09f94: 8260923: Add more tests for SSLSocket input/output shutdown
  • c00a72f: 8253631: Remove unimplemented CompileBroker methods after JEP-165
  • 21345ef: 8269847: JDK-8269594 backport breaks 11u builds
  • 73e987c: 8269594: assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark
  • 71f793e: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
  • e56abca: 8268366: Incorrect calculation of has_fpu_registers in C1 linear scan
  • ... and 49 more: https://git.openjdk.java.net/jdk11u-dev/compare/f55ef1e033a769101e383792c3964da275fd4582...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 30, 2021
@tstuefe tstuefe marked this pull request as ready for review July 5, 2021 08:53
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 5, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 5, 2021

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Jul 9, 2021

I withdraw this PR since it caused test errors which would have to be backported too (https://bugs.openjdk.java.net/browse/JDK-8261661) and this is too unimportant an issue to burn those cycles right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant