-
Notifications
You must be signed in to change notification settings - Fork 253
8210959: JShell fails and exits when statement throws an exception whose message contains a '%'. #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ose message contains a '%' Reviewed-by: jlahoda
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
/label add backport |
|
@shipilev The label |
|
This backport pull request has now been updated with issue from the original commit. |
jerboaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Received the approval too. /integrate |
This is unclean backport: there is a minor conflict in
@bugline in the test. Otherwise it applies cleanly. New test case fails without the patch, passes with it.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/64/head:pull/64$ git checkout pull/64Update a local copy of the PR:
$ git checkout pull/64$ git pull https://git.openjdk.java.net/jdk11u-dev pull/64/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 64View PR using the GUI difftool:
$ git pr show -t 64Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/64.diff