Skip to content

Conversation

@rnkovacs
Copy link
Contributor

@rnkovacs rnkovacs commented Aug 22, 2021

Changes apply cleanly.

This is part of the Windows/AArch64 port.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter

Contributors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/272/head:pull/272
$ git checkout pull/272

Update a local copy of the PR:
$ git checkout pull/272
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/272/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 272

View PR using the GUI difftool:
$ git pr show -t 272

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/272.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2021

👋 Welcome back rnkovacs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f6e26f6f33cd06ec4d8e911972a193aea9fab557 8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter Aug 22, 2021
@openjdk
Copy link

openjdk bot commented Aug 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 22, 2021
@openjdk
Copy link

openjdk bot commented Aug 22, 2021

@rnkovacs This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter

Co-authored-by: Monica Beckwith <[email protected]>

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 22, 2021
@rnkovacs
Copy link
Contributor Author

/contributor add Monica Beckwith [email protected]

@rnkovacs rnkovacs marked this pull request as ready for review August 22, 2021 17:14
@openjdk
Copy link

openjdk bot commented Aug 22, 2021

@rnkovacs
Contributor Monica Beckwith <[email protected]> successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 22, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2021

Webrevs

@rnkovacs
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 22, 2021
@openjdk
Copy link

openjdk bot commented Aug 22, 2021

@rnkovacs
Your change (at version ce3887b) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 24, 2021

Going to push as commit da90fbb.
Since your change was applied there have been 20 commits pushed to the master branch:

  • f334c2e: 8263136: C4530 was reported from VS 2019 at access bridge
  • 13ddf0e: 8261072: AArch64: Fix MacroAssembler::get_thread convention
  • 4699467: 8248816: C1: Fix signature conflict in LIRGenerator::strength_reduce_multiply
  • 4a3afd7: 8248657: Windows: strengthening in ThreadCritical regarding memory model
  • 8afb159: 8250824: AArch64: follow up for JDK-8248414
  • 6a6e00e: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
  • 83d916e: 8272772: Shenandoah: compiler/c2/aarch64/TestVolatilesShenandoah.java fails in 11u
  • 417b388: 8272472: StackGuardPages test doesn't build with glibc 2.34
  • a27ee49: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode
  • 4a2cd36: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
  • ... and 10 more: https://git.openjdk.java.net/jdk11u-dev/compare/f4772b52b80a5c95a33c5147f36b6686a021bc29...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 24, 2021
@openjdk
Copy link

openjdk bot commented Aug 24, 2021

@RealCLanger @rnkovacs Pushed as commit da90fbb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants