Skip to content

Conversation

@rnkovacs
Copy link
Contributor

@rnkovacs rnkovacs commented Aug 20, 2021

Changes apply cleanly.

This is part of the Windows/AArch64 port.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Contributors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/266/head:pull/266
$ git checkout pull/266

Update a local copy of the PR:
$ git checkout pull/266
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/266/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 266

View PR using the GUI difftool:
$ git pr show -t 266

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/266.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2021

👋 Welcome back rnkovacs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0417fcf13f7f2159499d325f2b3ace49d2643557 8248682: AArch64: Use ATTRIBUTE_ALIGNED helper Aug 20, 2021
@openjdk
Copy link

openjdk bot commented Aug 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 20, 2021
@openjdk
Copy link

openjdk bot commented Aug 20, 2021

@rnkovacs This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248682: AArch64: Use ATTRIBUTE_ALIGNED helper

Co-authored-by: Bernhard Urban-Forster <[email protected]>

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • f4772b5: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 20, 2021
@rnkovacs
Copy link
Contributor Author

/contributor add Bernhard Urban-Forster [email protected]

@rnkovacs rnkovacs marked this pull request as ready for review August 20, 2021 10:34
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 20, 2021
@openjdk
Copy link

openjdk bot commented Aug 20, 2021

@rnkovacs
Contributor Bernhard Urban-Forster <[email protected]> successfully added.

@mlbridge
Copy link

mlbridge bot commented Aug 20, 2021

Webrevs

@rnkovacs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 20, 2021

@rnkovacs
Your change (at version 4d52b05) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 20, 2021
@openjdk
Copy link

openjdk bot commented Aug 23, 2021

@RealCLanger Only the author (@rnkovacs) is allowed to issue the integrate command. As this PR is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

@RealCLanger
Copy link
Contributor

Same here, please wait for backport approval before "/integrate"-ing.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 23, 2021

Going to push as commit dfb67bc.
Since your change was applied there have been 6 commits pushed to the master branch:

  • c81c8e8: 8248671: AArch64: Remove unused variables
  • ba097ca: 8251549: Update docs on building for Git
  • 3a88ae7: Merge
  • 3a32efc: Merge
  • fdbaa23: Merge
  • f4772b5: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 23, 2021
@openjdk
Copy link

openjdk bot commented Aug 23, 2021

@RealCLanger @rnkovacs Pushed as commit dfb67bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants