8248657: Windows: strengthening in ThreadCritical regarding memory model

[rnkovacs]

Removed line L59 in src/hotspot/os/windows/threadCritical_windows.cpp has changed between 11 and tip (JDK-8234740), otherwise the backport is clean. Testing: tier1.

This is part of the Windows/AArch64 port.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8248657: Windows: strengthening in ThreadCritical regarding memory model

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Contributors

• Bernhard Urban-Forster <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/265/head:pull/265
$ git checkout pull/265

Update a local copy of the PR:
$ git checkout pull/265
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 265

View PR using the GUI difftool:
$ git pr show -t 265

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/265.diff

[bridgekeeper]

👋 Welcome back rnkovacs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[rnkovacs]

/contributor add Bernhard Urban-Forster [email protected]

[openjdk]

@rnkovacs
Contributor Bernhard Urban-Forster <[email protected]> successfully added.

[mlbridge]

Webrevs

• 00: Full (da93b2c3)

[luhenry]

@rnkovacs could we also attribute the contributor to the author of the change on jdk/jdk ([email protected])? Thank you!

[phohensee]

Tagged.

[openjdk]

@rnkovacs This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248657: Windows: strengthening in ThreadCritical regarding memory model

Co-authored-by: Bernhard Urban-Forster <[email protected]>
Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• f4772b5: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[rnkovacs]

Thanks!

[rnkovacs]

/integrate

[openjdk]

@rnkovacs
Your change (at version da93b2c) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit 4a3afd7.
Since your change was applied there have been 17 commits pushed to the master branch:

• 8afb159: 8250824: AArch64: follow up for JDK-8248414
• 6a6e00e: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
• 83d916e: 8272772: Shenandoah: compiler/c2/aarch64/TestVolatilesShenandoah.java fails in 11u
• 417b388: 8272472: StackGuardPages test doesn't build with glibc 2.34
• a27ee49: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode
• 4a2cd36: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
• 519894a: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
• 2d6c976: 8225790: Two NestedDialogs tests fail on Ubuntu
• 7b72611: 8213007: Update the link in test/jdk/sun/security/provider/SecureRandom/DrbgCavp.java
• bf01efa: 8248414: AArch64: Remove uses of long and unsigned long ints
• ... and 7 more: https://git.openjdk.java.net/jdk11u-dev/compare/90d529355b0fa36ca3378efae8dc6ba4b5203869...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @rnkovacs Pushed as commit 4a3afd7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.