8248671: AArch64: Remove unused variables

[rnkovacs]

Tiny change, applies cleanly.

This is part of the Windows/AArch64 port.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8248671: AArch64: Remove unused variables

Contributors

• Bernhard Urban-Forster <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/261/head:pull/261
$ git checkout pull/261

Update a local copy of the PR:
$ git checkout pull/261
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/261/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 261

View PR using the GUI difftool:
$ git pr show -t 261

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/261.diff

[bridgekeeper]

👋 Welcome back rnkovacs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[openjdk]

@rnkovacs This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248671: AArch64: Remove unused variables

Remove unused variables in the AArch64 backend. Detected by compiling with MSVC, which warns about them.

Co-authored-by: Bernhard Urban-Forster <[email protected]>

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• f4772b5: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[rnkovacs]

/issue add JDK-8254641

[openjdk]

@rnkovacs
Adding additional issue to issue list: 8254641: AArch64: Remove unused variables.

[rnkovacs]

/contributor add Bernhard Urban-Forster [email protected]

[openjdk]

@rnkovacs
Contributor Bernhard Urban-Forster <[email protected]> successfully added.

[mlbridge]

Webrevs

• 00: Full (ae062b06)

[rnkovacs]

/issue remove JDK-8254641

[openjdk]

@rnkovacs
Removing additional issue from issue list: 8254641.

[rnkovacs]

/integrate

[openjdk]

@rnkovacs
Your change (at version ae062b0) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit c81c8e8.
Since your change was applied there have been 5 commits pushed to the master branch:

• ba097ca: 8251549: Update docs on building for Git
• 3a88ae7: Merge
• 3a32efc: Merge
• fdbaa23: Merge
• f4772b5: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @rnkovacs Pushed as commit c81c8e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[RealCLanger]

@rnkovacs You need to request push approval for jdk11u backports, even when a PR is marked as "ready". So you should have waited with /integrate until the JBS issue (https://bugs.openjdk.java.net/browse/JDK-8248671) has label jdk11u-fix-xes.

I have approved and sponsored this now.

[rnkovacs]

@RealCLanger Sorry about that - I was so focused on getting the GH workflow right, I forgot that's still needed. I've requested authorship so that I can do the JBS administration myself (it's inconvenient to ask someone all the time). The two commits you've pushed for me should be enough - thank you!

[RealCLanger]

@RealCLanger Sorry about that - I was so focused on getting the GH workflow right, I forgot that's still needed. I've requested authorship so that I can do the JBS administration myself (it's inconvenient to ask someone all the time). The two commits you've pushed for me should be enough - thank you!

Yeah, no problem. I just wanted to make you aware of that. Ideally, maintainer approvals should also be handled via GitHub - I'll continue to propose that to Skara folks. With authorship in JBS it will at least be less cumbersome.