8287517: C2: assert(vlen_in_bytes == 64) failed: 2 #8961

sviswa7 · 2022-05-31T23:02:18Z

Fixed the assertion in load_iota_indices when the length passed is less than 4.
Also fixed the missing break in x86.ad match_rule_supported_vector() for PopulateIndex case.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8287517: C2: assert(vlen_in_bytes == 64) failed: 2

Reviewers

Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to 37639f5f
Jie Fu (@DamonFool - Reviewer) ⚠️ Review applies to 37639f5f
Christian Hagedorn (@chhagedorn - Reviewer) ⚠️ Review applies to 37639f5f
Fei Gao (@fg1417 - Author) ⚠️ Review applies to 37639f5f

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8961/head:pull/8961
$ git checkout pull/8961

Update a local copy of the PR:
$ git checkout pull/8961
$ git pull https://git.openjdk.java.net/jdk pull/8961/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8961

View PR using the GUI difftool:
$ git pr show -t 8961

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8961.diff

bridgekeeper · 2022-05-31T23:02:41Z

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-05-31T23:06:09Z

@sviswa7 The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-05-31T23:13:13Z

Webrevs

DamonFool · 2022-05-31T23:29:56Z

Shall we make a jtreg test for this fix?
Thanks.

chhagedorn · 2022-06-01T09:20:23Z

Shall we make a jtreg test for this fix? Thanks.

That would be helpful. @sviswa7 I've attached a simpler reproducer to the JBS bug extracted from the full fuzzer test.

sviswa7 · 2022-06-02T00:50:24Z

@chhagedorn Thanks a lot. I will look into creating a jtreg based on the simpler reproducer.

vnkozlov

Looks good. Waiting new test.

sviswa7 · 2022-06-03T00:29:47Z

@vnkozlov @chhagedorn @DamonFool I have added the regression test. Please take a look.

DamonFool · 2022-06-03T00:38:06Z

test/hotspot/jtreg/compiler/vectorization/cr8287517.java

+* @bug 8287517
+* @summary Test bug fix for JDK-8287517 related to fuzzer test failure in x86_64
+* @requires vm.compiler2.enabled
+* @requires (os.simpleArch == "x64" & vm.cpu.features ~= ".*avx2.*") |


Maybe, we can remove this require so that other platforms can also get tested.

@DamonFool I removed requires from the test as you suggested. Thanks.

DamonFool

LGTM
Thanks for the update.

openjdk · 2022-06-03T01:10:13Z

@sviswa7 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287517: C2: assert(vlen_in_bytes == 64) failed: 2

Reviewed-by: kvn, jiefu, chagedorn, fgao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

ce5ae51: 8287637: Loom: Mismatched VirtualThread::state accessor
59e9700: 8252717: Integrate/merge legacy standard doclet diagnostics and doclint
28c112f: 8287685: [BACKOUT] JDK-8287384 Speed up jdk.test.lib.util.ForceGC
34bb0a5: 8287734: Shenandoah: Consolidate marking closures
33b9d77: 8287729: Loom: Check alternative implementation on x86_32
a75299c: 8287686: Add assertion to ensure that disarm value offset < 128
407abf5: 8233477: [Win LAF]The tooltip doesn't display correctly in Win LAF
625821d: 8287661: Fix and improve BitMap::print_on(outputStream*)
b544b8b: 8276789: Support C++ lambda in ResourceHashtable::iterate
ba9ee8c: 8287748: Fix issues in java.lang.foreign package javadoc
... and 45 more: https://git.openjdk.java.net/jdk/compare/97bd4c255a319ce626a316ed211ef1fd7d0f1e14...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

vnkozlov

Looks good. I submitted testing.

sviswa7 · 2022-06-03T02:01:45Z

Thanks a lot @vnkozlov @DamonFool.

vnkozlov · 2022-06-03T05:29:19Z

Testing results are good. You can push.

chhagedorn

Otherwise, looks good! Thanks for adding a test.

chhagedorn · 2022-06-03T07:54:34Z

test/hotspot/jtreg/compiler/vectorization/cr8287517.java

+
+package compiler.vectorization;
+
+public class cr8287517 {


Please rename the test to something that describes the problem you are writing this test for instead of just using the bug number.

@chhagedorn Thanks, changed test name to TestSmallVectorPopIndex.java.

sviswa7 · 2022-06-03T17:50:28Z

Thanks a lot @vnkozlov.

sviswa7 · 2022-06-03T17:58:23Z

/integrate

openjdk · 2022-06-03T17:59:54Z

Going to push as commit a0219da.
Since your change was applied there have been 55 commits pushed to the master branch:

ce5ae51: 8287637: Loom: Mismatched VirtualThread::state accessor
59e9700: 8252717: Integrate/merge legacy standard doclet diagnostics and doclint
28c112f: 8287685: [BACKOUT] JDK-8287384 Speed up jdk.test.lib.util.ForceGC
34bb0a5: 8287734: Shenandoah: Consolidate marking closures
33b9d77: 8287729: Loom: Check alternative implementation on x86_32
a75299c: 8287686: Add assertion to ensure that disarm value offset < 128
407abf5: 8233477: [Win LAF]The tooltip doesn't display correctly in Win LAF
625821d: 8287661: Fix and improve BitMap::print_on(outputStream*)
b544b8b: 8276789: Support C++ lambda in ResourceHashtable::iterate
ba9ee8c: 8287748: Fix issues in java.lang.foreign package javadoc
... and 45 more: https://git.openjdk.java.net/jdk/compare/97bd4c255a319ce626a316ed211ef1fd7d0f1e14...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-06-03T18:00:08Z

@sviswa7 Pushed as commit a0219da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8287517: C2: assert(vlen_in_bytes == 64) failed: 2

84973db

openjdk bot added the hotspot-compiler [email protected] label May 31, 2022

sviswa7 marked this pull request as ready for review May 31, 2022 23:07

openjdk bot added the rfr Pull request is ready for review label May 31, 2022

fg1417 mentioned this pull request Jun 2, 2022

8283091: Support type conversion between different data sizes in SLP #7806

Closed

3 tasks

vnkozlov reviewed Jun 2, 2022

View reviewed changes

sviswa7 added 2 commits June 2, 2022 17:04

Add regression test

1939a73

Remove requires from test

37639f5

DamonFool reviewed Jun 3, 2022

View reviewed changes

DamonFool approved these changes Jun 3, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 3, 2022

vnkozlov approved these changes Jun 3, 2022

View reviewed changes

chhagedorn approved these changes Jun 3, 2022

View reviewed changes

fg1417 approved these changes Jun 3, 2022

View reviewed changes

Change test name

dd5adae

openjdk bot added the integrated Pull request has been integrated label Jun 3, 2022

openjdk bot closed this Jun 3, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 3, 2022

sviswa7 deleted the JDK-8287517 branch June 3, 2024 21:29

8287517: C2: assert(vlen_in_bytes == 64) failed: 2 #8961

8287517: C2: assert(vlen_in_bytes == 64) failed: 2 #8961

Uh oh!

Conversation

sviswa7 commented May 31, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented May 31, 2022

Uh oh!

openjdk bot commented May 31, 2022

Uh oh!

mlbridge bot commented May 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

DamonFool commented May 31, 2022

Uh oh!

chhagedorn commented Jun 1, 2022

Uh oh!

sviswa7 commented Jun 2, 2022

Uh oh!

vnkozlov left a comment

Choose a reason for hiding this comment

Uh oh!

sviswa7 commented Jun 3, 2022

Uh oh!

DamonFool Jun 3, 2022

Choose a reason for hiding this comment

Uh oh!

sviswa7 Jun 3, 2022

Choose a reason for hiding this comment

Uh oh!

DamonFool left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Jun 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vnkozlov left a comment

Choose a reason for hiding this comment

Uh oh!

sviswa7 commented Jun 3, 2022

Uh oh!

vnkozlov commented Jun 3, 2022

Uh oh!

chhagedorn left a comment

Choose a reason for hiding this comment

Uh oh!

chhagedorn Jun 3, 2022

Choose a reason for hiding this comment

Uh oh!

sviswa7 Jun 3, 2022

Choose a reason for hiding this comment

Uh oh!

sviswa7 commented Jun 3, 2022

Uh oh!

sviswa7 commented Jun 3, 2022

Uh oh!

openjdk bot commented Jun 3, 2022

Uh oh!

openjdk bot commented Jun 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

sviswa7 commented May 31, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented May 31, 2022 •

edited

Loading

openjdk bot commented Jun 3, 2022 •

edited

Loading