Skip to content

Conversation

@bplb
Copy link
Member

@bplb bplb commented Oct 10, 2025

Map Windows error codes ERROR_NETWORK_ACCESS_DENIED and ERROR_PRIVILEGE_NOT_HELD to java.nio.file.AccessDeniedException.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368907: (fs) Windows Error code 1314 not translated to AccessDeniedException (win) (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27753/head:pull/27753
$ git checkout pull/27753

Update a local copy of the PR:
$ git checkout pull/27753
$ git pull https://git.openjdk.org/jdk.git pull/27753/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27753

View PR using the GUI difftool:
$ git pr show -t 27753

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27753.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2025

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@bplb
Copy link
Member Author

bplb commented Oct 10, 2025

Note that the error code ERROR_NETWORK_ACCESS_DENIED is added to WindowsConstants. The only place this code appears elsewhere in the source base is in wepoll so perhaps we do not want to add it here.

@openjdk
Copy link

openjdk bot commented Oct 10, 2025

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368907: (fs) Windows Error code 1314 not translated to AccessDeniedException (win)

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 112 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Oct 10, 2025

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 10, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2025

Webrevs

@bplb bplb changed the title 8368907: Windows Error code 1314 not translated to AccessDeniedException (win) 8368907: (fs) Windows Error code 1314 not translated to AccessDeniedException (win) Oct 10, 2025
@AlanBateman
Copy link
Contributor

AlanBateman commented Oct 11, 2025

Need to delete the stray file #UnixPath.java#‎ that has sneaked into your branch :-)

@bplb
Copy link
Member Author

bplb commented Oct 13, 2025

Need to delete the stray file #UnixPath.java#‎ that has sneaked into your branch :-)

Emacs messed me up.

@bplb
Copy link
Member Author

bplb commented Oct 13, 2025

Need to delete the stray file #UnixPath.java#

Removed in 49e05eb.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 14, 2025
@bplb
Copy link
Member Author

bplb commented Oct 14, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2025

Going to push as commit 65b8fe6.
Since your change was applied there have been 124 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2025
@openjdk openjdk bot closed this Oct 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2025
@openjdk
Copy link

openjdk bot commented Oct 14, 2025

@bplb Pushed as commit 65b8fe6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the AccessDeniedException-8368907 branch October 14, 2025 17:49
@iseki0
Copy link

iseki0 commented Oct 15, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated nio [email protected]

Development

Successfully merging this pull request may close these issues.

3 participants