-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8368907: (fs) Windows Error code 1314 not translated to AccessDeniedException (win) #27753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back bpb! A progress list of the required criteria for merging this PR into |
|
Note that the error code ERROR_NETWORK_ACCESS_DENIED is added to WindowsConstants. The only place this code appears elsewhere in the source base is in wepoll so perhaps we do not want to add it here. |
|
@bplb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 112 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
|
Need to delete the stray file #UnixPath.java# that has sneaked into your branch :-) |
Emacs messed me up. |
Removed in 49e05eb. |
|
/integrate |
|
Going to push as commit 65b8fe6.
Your commit was automatically rebased without conflicts. |
|
? |
Map Windows error codes ERROR_NETWORK_ACCESS_DENIED and ERROR_PRIVILEGE_NOT_HELD to
java.nio.file.AccessDeniedException.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27753/head:pull/27753$ git checkout pull/27753Update a local copy of the PR:
$ git checkout pull/27753$ git pull https://git.openjdk.org/jdk.git pull/27753/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27753View PR using the GUI difftool:
$ git pr show -t 27753Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27753.diff
Using Webrev
Link to Webrev Comment