-
Notifications
You must be signed in to change notification settings - Fork 6.3k
8368968: FloatingDecimal: Clean up unused code #27581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back j3graham! A progress list of the required criteria for merging this PR into |
@j3graham This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rgiulietti) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
src/java.base/share/classes/jdk/internal/math/FloatingDecimal.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: Raffaello Giulietti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
Thanks @j3graham for the quick turnaround.
/integrate |
/sponsor |
Going to push as commit db6320d.
Your commit was automatically rebased without conflicts. |
@rgiulietti @j3graham Pushed as commit db6320d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a followup to #27118, to clean up resulting unused code.
getChars
,isExceptional
andisNegative
ExceptionalBinaryToASCIIBuffer
; throwsIllegalArgumentException
instead of returning an instance of that.(Caller already asserts non-exceptional arg)Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27581/head:pull/27581
$ git checkout pull/27581
Update a local copy of the PR:
$ git checkout pull/27581
$ git pull https://git.openjdk.org/jdk.git pull/27581/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27581
View PR using the GUI difftool:
$ git pr show -t 27581
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27581.diff
Using Webrev
Link to Webrev Comment