Skip to content

Conversation

jcking
Copy link
Contributor

@jcking jcking commented Sep 30, 2025

Remove deadcode.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368962: hotspot/cpu/aarch64/bytecodes_aarch64.{hpp,cpp} is unused (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27577/head:pull/27577
$ git checkout pull/27577

Update a local copy of the PR:
$ git checkout pull/27577
$ git pull https://git.openjdk.org/jdk.git pull/27577/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27577

View PR using the GUI difftool:
$ git pr show -t 27577

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27577.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2025

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 30, 2025

@jcking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368962: hotspot/cpu/aarch64/bytecodes_aarch64.{hpp,cpp} is unused

Reviewed-by: aph, mhaessig

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8368962: hotspot/cpu/aarch64/bytecodes_aarch64.{hpp,cpp} is unused 8368962: hotspot/cpu/aarch64/bytecodes_aarch64.{hpp,cpp} is unused Sep 30, 2025
@openjdk
Copy link

openjdk bot commented Sep 30, 2025

@jcking The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 30, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2025

Webrevs

Copy link
Contributor

@theRealAph theRealAph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 30, 2025
@jcking
Copy link
Contributor Author

jcking commented Sep 30, 2025

@theRealAph Do we want to wait for a second reviewer, or are we good with just one given this is a simple delete?

@mhaessig
Copy link
Contributor

I kicked off a small testing run on our side just to be sure. Should be done in 2h.

@theRealAph
Copy link
Contributor

@theRealAph Do we want to wait for a second reviewer, or are we good with just one given this is a simple delete?

I think this fine and trivially correct, but we need two reviews for HotSpot patches. I've been told off before when I didn't do this. 😇

Copy link
Contributor

@mhaessig mhaessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and testing passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants