8368953: Document the reason why Serial/Parallel/G1 use zero as dirty card value

[tschatzl]

Hi all,

please review this trivial change to document the reason for the dirty/clean card value selection.

Testing: local compilation

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8368953: Document the reason why Serial/Parallel/G1 use zero as dirty card value (Enhancement - P4)

Reviewers

• Ivan Walulya (@walulyai - Reviewer) Review applies to d103feb7
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Contributors

• Albert Mingkun Yang <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27575/head:pull/27575
$ git checkout pull/27575

Update a local copy of the PR:
$ git checkout pull/27575
$ git pull https://git.openjdk.org/jdk.git pull/27575/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27575

View PR using the GUI difftool:
$ git pr show -t 27575

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27575.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368953: Document the reason why Serial/Parallel/G1 use zero as dirty card value

Co-authored-by: Albert Mingkun Yang <[email protected]>
Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• fe9dbcc: 8368599: ShenandoahConcurrentMark could use ThreadsClaimTokenScope
• 07ecc93: 8367692: RISC-V: Align post call nop
• 6b4b102: 8368809: JFR: Remove events from testSettingConfiguration in TestActiveSettingEvent
• ... and 5 more: https://git.openjdk.org/jdk/compare/ba0a6eed1a6a22bd4c1d159592b62e054afa401a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (cef01833)
• 00: Full (d103feb7)

[tschatzl]

/contributor add @albertnetymk

[openjdk]

@tschatzl
Contributor Albert Mingkun Yang <[email protected]> successfully added.

[tschatzl]

Thanks @albertnetymk @walulyai for your reviews
/integrate

[openjdk]

Going to push as commit 6c2d383.
Since your change was applied there have been 14 commits pushed to the master branch:

• 1188ca5: 8368954: G1: Document why G1 uses TLS storage for the current card table reference
• 394eb80: 8368957: Remove metaprogramming/logical.hpp in favor of C++17 facilities
• 8c3ca02: 8368817: Convert JDK_Version::to_string to use stringStream instead of jio_snprintf-chain
• ... and 11 more: https://git.openjdk.org/jdk/compare/ba0a6eed1a6a22bd4c1d159592b62e054afa401a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 6c2d383.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.