8368885: NMT CommandLine tests can check for error better

[jdksjolen]

We can check for more specific error text when running the command line tests, the current 'error' string check misses NMT parsing succeeding but NMT initialization failure.

We also fix the indentation of the test files, let's use 4 spaces in the Java source files.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8368885: NMT CommandLine tests can check for error better (Bug - P4)

Reviewers

• Paul Hübner (@Arraying - Author)
• Afshin Zafari (@afshin-zafari - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27554/head:pull/27554
$ git checkout pull/27554

Update a local copy of the PR:
$ git checkout pull/27554
$ git pull https://git.openjdk.org/jdk.git pull/27554/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27554

View PR using the GUI difftool:
$ git pr show -t 27554

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27554.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jdksjolen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368885: NMT CommandLine tests can check for error better

Reviewed-by: phubner, azafari, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 07ecc93: 8367692: RISC-V: Align post call nop
• 6b4b102: 8368809: JFR: Remove events from testSettingConfiguration in TestActiveSettingEvent
• 8cc54ec: 8368563: JFR: Improve jfr query help text
• ... and 28 more: https://git.openjdk.org/jdk/compare/af8fb20ac0325a231ee14bd72e9764e02ca07681...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jdksjolen The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3a6aa261)

[Arraying]

Thanks!

[afshin-zafari]

Thanks for taking this. LGTM.

[shipilev]

Makes sense, thanks.

[jdksjolen]

/integrate

[openjdk]

Going to push as commit 84e5d63.
Since your change was applied there have been 40 commits pushed to the master branch:

• f49849a: 8368893: RISC-V: crash after JDK-8352673 on fastdebug version
• 6c2d383: 8368953: Document the reason why Serial/Parallel/G1 use zero as dirty card value
• 1188ca5: 8368954: G1: Document why G1 uses TLS storage for the current card table reference
• ... and 37 more: https://git.openjdk.org/jdk/compare/af8fb20ac0325a231ee14bd72e9764e02ca07681...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jdksjolen Pushed as commit 84e5d63.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.