8351594: JFR: Rate-limited sampling of Java events

[egahlin]

Could I have review of an enhancement that adds rate-limited sampling to Java events, including five events in the JDK (SocketRead, SocketWrite, FileRead, FileWrite, and JavaExceptionThrow).

Testing: test/jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8354232 to be approved
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

• JDK-8351594: JFR: Rate-limited sampling of Java events (Enhancement - P3)
• JDK-8354232: JFR: Rate-limited sampling of Java events (CSR)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25559/head:pull/25559
$ git checkout pull/25559

Update a local copy of the PR:
$ git checkout pull/25559
$ git pull https://git.openjdk.org/jdk.git pull/25559/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25559

View PR using the GUI difftool:
$ git pr show -t 25559

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25559.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351594: JFR: Rate-limited sampling of Java events

Reviewed-by: mgronlun, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• c5daf89: 8349369: test/docs/jdk/javadoc/doccheck/checks/jdkCheckLinks.java did not report on missing man page files
• bd08932: 8356633: Incorrect use of {@link} in jdk.jshell
• d450e34: 8357962: JFR Cooperative Sampling reveals inconsistent interpreter frames as part of JVMTI PopFrame
• ... and 2 more: https://git.openjdk.org/jdk/compare/ace70a6d6aca619da34b2f9cac2586cc88cefb5a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following labels will be automatically applied to this pull request:

• build
• core-libs
• hotspot-jfr
• net
• nio
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[egahlin]

/label remove build, security, nio

[openjdk]

@egahlin
The build label was successfully removed.

The security label was successfully removed.

The nio label was successfully removed.

[mlbridge]

Webrevs

• 08: Full - Incremental (45adc081)
• 07: Full - Incremental (8beb194a)
• 06: Full - Incremental (7f26f172)
• 05: Full - Incremental (8259ff41)
• 04: Full - Incremental (535d458a)
• 03: Full - Incremental (59278ca8)
• 02: Full - Incremental (7fa2db19)
• 01: Full - Incremental (d0097506)
• 00: Full (73943e7a)

[AlanBateman]

The usages are much cleaner in the update so I think this all good.

[egahlin]

Thanks for the reviews, the offer methods turned out nicely.

[egahlin]

/integrate

[openjdk]

@egahlin This pull request has not yet been marked as ready for integration.

[egahlin]

/integrate

[openjdk]

Going to push as commit eb770a0.
Since your change was applied there have been 5 commits pushed to the master branch:

• c5daf89: 8349369: test/docs/jdk/javadoc/doccheck/checks/jdkCheckLinks.java did not report on missing man page files
• bd08932: 8356633: Incorrect use of {@link} in jdk.jshell
• d450e34: 8357962: JFR Cooperative Sampling reveals inconsistent interpreter frames as part of JVMTI PopFrame
• ... and 2 more: https://git.openjdk.org/jdk/compare/ace70a6d6aca619da34b2f9cac2586cc88cefb5a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit eb770a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.