-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8341346: Add support for exporting TLS Keying Material #24976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back wetmore! A progress list of the required criteria for merging this PR into |
|
@bradfordwetmore This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@bradfordwetmore The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java
Outdated
Show resolved
Hide resolved
…erification and unit testing
|
@bradfordwetmore this pull request can not be integrated into git checkout JDK-8341346
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
src/java.base/share/classes/com/sun/crypto/provider/TlsPrfGenerator.java
Show resolved
Hide resolved
src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/sun/security/internal/spec/TlsPrfParameterSpec.java
Outdated
Show resolved
Hide resolved
test/jdk/javax/net/ssl/ExtendedSSLSession/ExportKeyingMaterialTests.java
Show resolved
Hide resolved
|
/integrate |
|
@bradfordwetmore Pushed as commit 2926435. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE respectively.
CSR is complete/approved.
Tests include new unit tests for TLSv1-1.3. Have run tier1-2, plus the JCK API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24976/head:pull/24976$ git checkout pull/24976Update a local copy of the PR:
$ git checkout pull/24976$ git pull https://git.openjdk.org/jdk.git pull/24976/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24976View PR using the GUI difftool:
$ git pr show -t 24976Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24976.diff
Using Webrev
Link to Webrev Comment