8353188: C1: Clean up x86 backend after 32-bit x86 removal

[shipilev]

Piece-wise cleanup of C1_LIRAssembler_x86, C1_MacroAssembler and related classes. C1 implements the bulk of arch-specific backend there. Major parts of this backend are already removed by #24274, this cleans up another large bulk, and hopefully most of it.

Additional testing:

• Linux x86_64 server fastdebug, all
• Linux x86_64 server fastdebug, all + -XX:TieredStopAtLevel=1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353188: C1: Clean up x86 backend after 32-bit x86 removal (Sub-task - P4)

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer) Review applies to 527854ec
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24301/head:pull/24301
$ git checkout pull/24301

Update a local copy of the PR:
$ git checkout pull/24301
$ git pull https://git.openjdk.org/jdk.git pull/24301/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24301

View PR using the GUI difftool:
$ git pr show -t 24301

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24301.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353188: C1: Clean up x86 backend after 32-bit x86 removal

Reviewed-by: kvn, vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

• d894b78: 8353588: [REDO] DaCapo xalan performance with -XX:+UseObjectMonitorTable
• db08726: 8352966: Opensource Several Font related tests - Batch 2
• 6b7b324: 8351431: Type annotations on new class creation expressions can't be retrieved
• 64b691a: 8271870: G1: Add objArray splitting when scanning object with evacuation failure
• b428cda: 8349686: [s390x] C1: Improve Class.isInstance intrinsic
• 70e3250: 8352419: Test tools/jpackage/share/ErrorTest.java#id0 and #id1 fail
• 296d9d6: 8353345: C2 asserts because maskShiftAmount modifies node without deleting the hash
• 3ceabf0: 8353359: C2: Or(I|L)Node::Ideal is missing AddNode::Ideal call
• b263292: 8353484: JFR: Simplify EventConfiguration
• ffca4f2: 8353264: ZGC: Windows heap unreserving is broken
• ... and 70 more: https://git.openjdk.org/jdk/compare/23e3b3ff6ab17a71b16fdf2e61548a7413ddb6d4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@shipilev this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8353188-x86-c1-backend
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[mlbridge]

Webrevs

• 02: Full - Incremental (77262978)
• 01: Full - Incremental (527854ec)
• 00: Full (47f239c2)

[iwanowww]

Looks good.

[iwanowww]

Looks good.

[shipilev]

Thanks! Testing looks green. I need another Reviewer before I integrate.

[vnkozlov]

Good.

[shipilev]

Thanks! I have spot-checked that the merge with master yields no surprises. So I am integrating.

/integrate

[openjdk]

Going to push as commit d63b561.
Since your change was applied there have been 108 commits pushed to the master branch:

• d1e91fc: 8353344: RISC-V: Detect and enable several extensions for debug builds
• 6abf4e6: 8353568: SEGV_BNDERR signal code adjust definition
• 6d9ece7: 8351949: RISC-V: Cleanup and enable store-load peephole for membars
• 97ed536: 8346989: C2: deoptimization and re-execution cycle with Math.*Exact in case of frequent overflow
• 660b17a: 8350852: Implement JMH benchmark for sparse CodeCache
• 6d37e63: 8353753: Remove unnecessary forward declaration in oop.hpp
• 9bb804b: 8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java
• e17c399: 8353201: Open source Swing Tooltip tests - Set 2
• 9fcb06f: 8352997: Open source several Swing JTabbedPane tests
• 74c2d8f: 8353320: Open source more Swing text tests
• ... and 98 more: https://git.openjdk.org/jdk/compare/23e3b3ff6ab17a71b16fdf2e61548a7413ddb6d4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit d63b561.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.