8345298: RISC-V: Add riscv backend for Float16 operations - scalar #23844
Conversation
|
👋 Welcome back mli! A progress list of the required criteria for merging this PR into |
|
@Hamlin-Li This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 97 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@Hamlin-Li this pull request can not be integrated into git checkout float16-scalar
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
openjdk
bot
added
merge-conflict
|
@Hamlin-Li The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
openjdk
bot
removed
the
merge-conflict
Webrevs
|
RealFYang
left a comment
RealFYang
left a comment
There was a problem hiding this comment.
Hi, Thanks for working on this part. Some initial comments after a cursory look.
openjdk
bot
added
the
merge-conflict
openjdk
bot
removed
the
merge-conflict
|
BTW, I just removed TestFloat16VectorConvChain test for riscv temporariely, as with this patch the ConvF2HF(AddF(ConvHF2F, ConvHF2F)) will be replaced by a ReinterpretHF2S(AddHF(ReinterpretS2HF, ReinterpretS2HF)). In the short future, when we support vectorization of float16 operations, we can enable the test, but for riscv it will still be different form of Nodes, could be something like VectorReinterpretHF2S(VectorAddHF(VectorReinterpretS2HF, VectorReinterpretS2HF)). |
RealFYang
left a comment
RealFYang
left a comment
There was a problem hiding this comment.
Several more comments after a closer look.
Maybe we should also update the |
No, as this test is for "vector conversion chain", only support of |
That makes sense to me. Thanks. |
RealFYang
left a comment
RealFYang
left a comment
There was a problem hiding this comment.
Thanks for the update. There minor comments remain. Seems fine to me otherwise.
RealFYang
left a comment
RealFYang
left a comment
There was a problem hiding this comment.
Overall LGTM. Thanks for the updates.
Thank you! |
|
/integrate |
|
Going to push as commit a33b1f7.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
|
@Hamlin-Li Pushed as commit a33b1f7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
3 participants
Hi,
Can you help to review this patch?
It's an implementation of #22754 on riscv.
Performance
data
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23844/head:pull/23844$ git checkout pull/23844Update a local copy of the PR:
$ git checkout pull/23844$ git pull https://git.openjdk.org/jdk.git pull/23844/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23844View PR using the GUI difftool:
$ git pr show -t 23844Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23844.diff
Using Webrev
Link to Webrev Comment