-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8350134: Support DHKEM with PKCS11 #23651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back weijun! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Webrevs
|
|
@wangweij This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@wangweij This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
|
/open |
|
@wangweij This pull request is now open |
|
@wangweij this pull request can not be integrated into git checkout 8350134
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
This code change adds supports for getting public key from an EC private key and slicing a secret key in PKCS #11. These are necessary to support DHKEM for keys in SunPKCS11. The first support is still not complete and there is no way to get the public key if the private key is unwrapped from an encrypted form. PKCS #11 3.0 defined CKA_PUBLIC_KEY_INFO but I haven't yet found a library supporting it.
Progress
Warnings
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23651/head:pull/23651$ git checkout pull/23651Update a local copy of the PR:
$ git checkout pull/23651$ git pull https://git.openjdk.org/jdk.git pull/23651/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23651View PR using the GUI difftool:
$ git pr show -t 23651Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23651.diff
Using Webrev
Link to Webrev Comment