Skip to content

Conversation

@wenshao
Copy link
Contributor

@wenshao wenshao commented Feb 3, 2025

The comment in the PR review of that issue #19626 (comment) explains what the issue is with the change that was integrated.

The putCharsAt method of StringLatin1 and StringUTF16 does not perform boundary checking and writes directly without error in concurrent scenarios.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23423/head:pull/23423
$ git checkout pull/23423

Update a local copy of the PR:
$ git checkout pull/23423
$ git pull https://git.openjdk.org/jdk.git pull/23423/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23423

View PR using the GUI difftool:
$ git pr show -t 23423

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23423.diff

@wenshao wenshao changed the title StringLatin1/StringUTF16 putCharsAt checkBoundsBeginEnd StringLatin1 & StringUTF16 putCharsAt checkBoundsBeginEnd Feb 3, 2025
@wenshao wenshao changed the title StringLatin1 & StringUTF16 putCharsAt checkBoundsBeginEnd StringLatin1 & StringUTF16::putCharsAt add checkBoundsBeginEnd Feb 3, 2025
@wenshao wenshao changed the title StringLatin1 & StringUTF16::putCharsAt add checkBoundsBeginEnd StringLatin1 & StringUTF16::putCharsAt checkBoundsBeginEnd Feb 3, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 3, 2025

👋 Welcome back swen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 3, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Feb 3, 2025

@wenshao The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link

openjdk bot commented Feb 3, 2025

@wenshao this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout fix_append_202502
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Feb 3, 2025
@wenshao wenshao closed this Feb 3, 2025
@wenshao wenshao deleted the fix_append_202502 branch February 6, 2025 08:21
@wenshao wenshao restored the fix_append_202502 branch February 6, 2025 08:21
@wenshao
Copy link
Contributor Author

wenshao commented Feb 6, 2025

/open

@wenshao wenshao reopened this Feb 6, 2025
@openjdk
Copy link

openjdk bot commented Feb 6, 2025

@wenshao This pull request is already open

@wenshao wenshao closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs [email protected] merge-conflict Pull request has merge conflict with target branch

Development

Successfully merging this pull request may close these issues.

1 participant