Skip to content

Conversation

@JornVernee
Copy link
Member

@JornVernee JornVernee commented Jan 31, 2025

This reverts #23142

See the JBS issue. It seems that the changes are occasionally causing heap corruption, potentially due to use after free, which occasionally results in corrupt malloc headers being caught on mac. This failure was observed once in about 500 runs of this test, so it is quite intermittent.

Backing this change out seems the easiest/safest to clear up the tier 1 failure, until we've had a chance to investigate the issue further.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8348909: [BACKOUT] Implement a better allocator for downcalls (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23391/head:pull/23391
$ git checkout pull/23391

Update a local copy of the PR:
$ git checkout pull/23391
$ git pull https://git.openjdk.org/jdk.git pull/23391/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23391

View PR using the GUI difftool:
$ git pr show -t 23391

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23391.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2025

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 31, 2025

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348909: [BACKOUT] Implement a better allocator for downcalls

Reviewed-by: shade, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 31, 2025
@openjdk
Copy link

openjdk bot commented Jan 31, 2025

@JornVernee The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jan 31, 2025

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backout looks fine. Looks like the clean mechanical git revert, and therefore trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 31, 2025
@JornVernee
Copy link
Member Author

Backout looks fine. Looks like the clean mechanical git revert, and therefore trivial.

Yes, it's a clean git revert

@JornVernee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 31, 2025

Going to push as commit 7764742.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 31, 2025
@openjdk openjdk bot closed this Jan 31, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 31, 2025
@openjdk
Copy link

openjdk bot commented Jan 31, 2025

@JornVernee Pushed as commit 7764742.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants