-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8348909: [BACKOUT] Implement a better allocator for downcalls #23391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 8cc1304.
|
👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into |
|
@JornVernee This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
@JornVernee The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
shipilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backout looks fine. Looks like the clean mechanical git revert, and therefore trivial.
Yes, it's a clean |
|
/integrate |
|
Going to push as commit 7764742. |
|
@JornVernee Pushed as commit 7764742. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This reverts #23142
See the JBS issue. It seems that the changes are occasionally causing heap corruption, potentially due to use after free, which occasionally results in corrupt malloc headers being caught on mac. This failure was observed once in about 500 runs of this test, so it is quite intermittent.
Backing this change out seems the easiest/safest to clear up the tier 1 failure, until we've had a chance to investigate the issue further.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23391/head:pull/23391$ git checkout pull/23391Update a local copy of the PR:
$ git checkout pull/23391$ git pull https://git.openjdk.org/jdk.git pull/23391/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23391View PR using the GUI difftool:
$ git pr show -t 23391Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23391.diff
Using Webrev
Link to Webrev Comment