-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8344534: Remove leftover import of java.security.AccessControlContext in JavaLangAccess #22234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Channeling @AlanBateman to have a look. |
|
👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into |
|
@eirbjo This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
AlanBateman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay but hardly worth doing as JLA is changed very frequently so any unused imports will be quickly removed.
Thanks Alan. I'll go ahead and integrate this now, but I'm taking note of your point for any future changes in similar contexts. /integrate |
|
Going to push as commit 2359736.
Your commit was automatically rebased without conflicts. |
Please review this trivial cleanup of an unused import of
AccessControlContextinJavaLangAccess.This was left over after #22035 removed
JavaLangAccess::newThreadWithAcc(Runnable, AccessControlContext).Verification:
make imagessucceeds.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22234/head:pull/22234$ git checkout pull/22234Update a local copy of the PR:
$ git checkout pull/22234$ git pull https://git.openjdk.org/jdk.git pull/22234/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22234View PR using the GUI difftool:
$ git pr show -t 22234Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22234.diff
Using Webrev
Link to Webrev Comment