8334342: Add MergeStore JMH benchmarks #19734
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back wenshao! A progress list of the required criteria for merging this PR into |
|
@wenshao This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@eme64, @TobiHartmann) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Contributor
Author
1. Cases MergeStore does not workFrom the results of running the test, the following method MergeStore does not work @eme64 Please help me find out what the reason is and whether it can be improved. 2. Performance numbersThe names of these cases have the following 2.1 MacBook M1 Pro (aarch64)2.2 MacBook 2018 i9 (x64)
2.3 Aliyun ecs.c8a (x64)
2.4 Aliyun ecs.c8i (x64)CPU CPU Intel® Xeon® Emerald 2.5 Aliyun ecs.c8y (aarch64)
2.6 Orange Pi 5 Plus (aarch64)
2.7 AWS ecs c5.xlarge (x64)2.8 AWS c7g.xlarge (aarch64) |
wenshao
changed the title
Webrevs
|
3 tasks
Contributor
|
A few extra comments: About your list: |
eme64
reviewed
Jun 17, 2024
Comment on lines
651
to
656
| static void setIntB(byte[] array, int offset, int value) { | ||
| array[offset ] = (byte) (value >> 24); | ||
| array[offset + 1] = (byte) (value >> 16); | ||
| array[offset + 2] = (byte) (value >> 8); | ||
| array[offset + 3] = (byte) (value ); | ||
| } |
Contributor
There was a problem hiding this comment.
You say that here MergeStore does not work. That is because the indices are increasing, but the shifts decreasing. So that does not work on little-endian machines (most architectures), but I would expect it to work on big-endian machines with #19218.
Contributor
Author
There was a problem hiding this comment.
Big endian is often used in network data transmission scenarios, and it is common to process big endian data on a little endian machine. In this case, can it be optimized to Integer.reverseBytes & putIntLittleEndian on a LittleEndian machine? setIntB -> setIntRL
Contributor
There was a problem hiding this comment.
I had already suggested that here:
#19218 (review)
Feel free to file an RFE. Maybe someone wants to work on it. I think it would not be that hard to make it work given all the code that is already there now. And it would be helpful in for both big/little endian to be able to do both orders.
Contributor
Author
|
I re-ran the performance test based on WebRevs 04: Full - Incremental (4c9b9418) . 1. Cases MergeStore does not work@eme64 I also found that the performance of the case using VarHandle is particularly good. Why? For example: 2. Performance numbersThe names of these cases have the following B/L/V/U suffixes, which are: 2.1 MacBook M1 Pro (aarch64)2.2 Aliyun ecs.c8a.xlarge (x64)
2.3 Aliyun ecs.c8i.xlarge (x64)
|
|
@wenshao This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Member
|
Should we leave this benchmark in |
Contributor
|
@liach we should move it to |
Contributor
|
@wenshao what is the state of this PR? |
Contributor
Author
|
It has been moved to vm/compiler. Can it be approved? |
Contributor
Author
|
Here are the performance numbers running on the new MacBook M1 Pro,
|
eme64
approved these changes
Jul 25, 2024
Contributor
eme64
left a comment
eme64
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for creating this benchmark! I'll definitely use it soon, when I try to extend MergeStores to more cases :)
Contributor
Author
|
/integrate |
Contributor
|
@wenshao generally we like to have at least 2 reviews before integration ;) |
Member
|
/labels add hotspot-compiler |
|
@TobiHartmann Unknown command |
Member
|
/label add hotspot-compiler |
|
@TobiHartmann |
Member
|
/sponsor |
|
Going to push as commit 8081f87.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
|
@TobiHartmann @wenshao Pushed as commit 8081f87. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8318446 brings MergeStore. We need a JMH Benchmark to evaluate the performance of various batch operations and the effect of MergeStore.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19734/head:pull/19734$ git checkout pull/19734Update a local copy of the PR:
$ git checkout pull/19734$ git pull https://git.openjdk.org/jdk.git pull/19734/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19734View PR using the GUI difftool:
$ git pr show -t 19734Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19734.diff
Webrev
Link to Webrev Comment