Skip to content

8332865: ubsan: os::attempt_reserve_memory_between reports overflow #19543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

8332865: ubsan: os::attempt_reserve_memory_between reports overflow #19543

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
983bda1
JDK-8332865
MBaesken Jun 4, 2024
80e5e94
add check suggested by Thomas Stuefe
MBaesken Jun 5, 2024
71c9162
reuse hi_end
MBaesken Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/hotspot/share/runtime/os.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1935,7 +1935,11 @@ char* os::attempt_reserve_memory_between(char* min, char* max, size_t bytes, siz
return nullptr; // overflow
}

char* const hi_att = align_down(MIN2(max, absolute_max) - bytes, alignment_adjusted);
char* const hi_end = MIN2(max, absolute_max);
if ((uintptr_t)hi_end < bytes) {
return nullptr; // no need to go on
}
char* const hi_att = align_down(hi_end - bytes, alignment_adjusted);
if (hi_att > max) {
return nullptr; // overflow
}
Expand Down