8305310: Calculate PublicKey from PrivateKey #13250

wangweij · 2023-03-30T19:31:47Z

This code change is for DHKEM, which requires the function

pk(skX): The KEM public key corresponding to the KEM private key skX.

Only implemented for EC and XDH. Might add PKCS #11 support later.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8305310: Calculate PublicKey from PrivateKey

Reviewers

Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13250/head:pull/13250
$ git checkout pull/13250

Update a local copy of the PR:
$ git checkout pull/13250
$ git pull https://git.openjdk.org/jdk.git pull/13250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13250

View PR using the GUI difftool:
$ git pr show -t 13250

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13250.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-03-30T19:32:57Z

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

only in patch2: unchanged:

openjdk · 2023-03-30T19:53:19Z

@wangweij The following label will be automatically applied to this pull request:

security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-03-30T19:57:36Z

Webrevs

01: Full - Incremental (afdd5a3a)
00: Full (48ecd5a0)

mpdonova · 2023-03-31T11:15:19Z

src/jdk.crypto.ec/share/classes/sun/security/ec/ECPrivateKeyImpl.java

+        try {
+            return new ECPublicKeyImpl(w, ecParams);
+        } catch (InvalidKeyException e) {
+            throw new ProviderException("Should not happen", e);


On the remote chance that this exception is thrown, the message doesn't help the user. A better message might be "Unexpected error creating public key" or even just not having a message and using the ProviderException(Throwable)constructor.

This message is also used in XDHPrivateKeyimpl.

Good suggestion.

mpdonova · 2023-03-31T11:47:39Z

test/jdk/sun/security/util/InteralPrivateKey/Correctness.java

+ * @summary Calculate PublicKey from PrivateKey
+ * @modules java.base/sun.security.util
+ */
+public class Correctness {


There's a misspelling in the directory name for this class: InteralPrivateKey vs. InternalPrivateKey

openjdk · 2023-04-07T14:51:17Z

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305310: Calculate PublicKey from PrivateKey

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 118 new commits pushed to the master branch:

a8871f5: 8305407: ExternalSpecsWriter should ignore white-space differences in spec titles
6b2a86a: 8300257: C2: vectorization fails on some simple Memory Segment loops
dc81603: 8305666: Add system property for fair AWT lock
c67bbce: 8305711: Arm: C2 always enters slowpath for monitorexit
ce6e746: 8305118: Add RISC-V related content to building.md
314e9b3: 8300829: Make CtwRunner available as an independent tool
0a34018: 8305680: Remove Permissions from jcmd help output
8db1dd0: 8305622: Remove Permission details from jcmd man page
1d517af: 8305209: JDWP exit error AGENT_ERROR_INVALID_THREAD(203): missing entry in running thread table
08fbb7b: 8272119: Typo in JDK documentation (a -> an)
... and 108 more: https://git.openjdk.org/jdk/compare/b3ff8d1c89b0f968b7b5ec2105502778524e4e4a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

wangweij · 2023-04-10T00:54:32Z

/integrate

openjdk · 2023-04-10T00:55:25Z

Going to push as commit 9727685.
Since your change was applied there have been 122 commits pushed to the master branch:

50d7335: 8305696: (zipfs) Avoid redundant LinkedHashMap.containsKey call ZipFileSystem.makeParentDirs
ec9d816: 6441827: Documentation mentions nonexistent NullReferenceException
9e20382: 8305721: add make compile-commands artifacts to .gitignore
f45b01f: 8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java
a8871f5: 8305407: ExternalSpecsWriter should ignore white-space differences in spec titles
6b2a86a: 8300257: C2: vectorization fails on some simple Memory Segment loops
dc81603: 8305666: Add system property for fair AWT lock
c67bbce: 8305711: Arm: C2 always enters slowpath for monitorexit
ce6e746: 8305118: Add RISC-V related content to building.md
314e9b3: 8300829: Make CtwRunner available as an independent tool
... and 112 more: https://git.openjdk.org/jdk/compare/b3ff8d1c89b0f968b7b5ec2105502778524e4e4a...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-04-10T00:55:36Z

@wangweij Pushed as commit 9727685.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

the fix

f42d936

add a test

48ecd5a

only in patch2: unchanged:

openjdk bot added the rfr Pull request is ready for review label Mar 30, 2023

openjdk bot added the security [email protected] label Mar 30, 2023

wangweij mentioned this pull request Mar 31, 2023

8297878: KEM: Implementation #13256

Closed

4 tasks

mpdonova reviewed Mar 31, 2023

View reviewed changes

exception message, directory name

afdd5a3

seanjmullan approved these changes Apr 7, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 7, 2023

openjdk bot added the integrated Pull request has been integrated label Apr 10, 2023

openjdk bot closed this Apr 10, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 10, 2023

wangweij deleted the 8305310 branch April 10, 2023 12:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8305310: Calculate PublicKey from PrivateKey #13250

8305310: Calculate PublicKey from PrivateKey #13250

Uh oh!

wangweij commented Mar 30, 2023 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Mar 30, 2023

Uh oh!

openjdk bot commented Mar 30, 2023

Uh oh!

mlbridge bot commented Mar 30, 2023 •

edited

Loading

Uh oh!

mpdonova Mar 31, 2023

Uh oh!

wangweij Mar 31, 2023

Uh oh!

mpdonova Mar 31, 2023

Uh oh!

wangweij Mar 31, 2023

Uh oh!

openjdk bot commented Apr 7, 2023

Uh oh!

wangweij commented Apr 10, 2023

Uh oh!

openjdk bot commented Apr 10, 2023

Uh oh!

openjdk bot commented Apr 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

8305310: Calculate PublicKey from PrivateKey #13250

8305310: Calculate PublicKey from PrivateKey #13250

Uh oh!

Conversation

wangweij commented Mar 30, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Mar 30, 2023

Uh oh!

openjdk bot commented Mar 30, 2023

Uh oh!

mlbridge bot commented Mar 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

mpdonova Mar 31, 2023

Choose a reason for hiding this comment

Uh oh!

wangweij Mar 31, 2023

Choose a reason for hiding this comment

Uh oh!

mpdonova Mar 31, 2023

Choose a reason for hiding this comment

Uh oh!

wangweij Mar 31, 2023

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Apr 7, 2023

Uh oh!

wangweij commented Apr 10, 2023

Uh oh!

openjdk bot commented Apr 10, 2023

Uh oh!

openjdk bot commented Apr 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

wangweij commented Mar 30, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Mar 30, 2023 •

edited

Loading