Skip to content

8296820: Add implementation note to SSLContext.getInstance noting subsequent behavior if protocol is disabled #11172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

8296820: Add implementation note to SSLContext.getInstance noting subsequent behavior if protocol is disabled #11172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a682001
Initial revision.
seanjmullan Nov 15, 2022
7817bf7
Update wording for SunJSSE provider.
seanjmullan Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/java.base/share/classes/javax/net/ssl/SSLContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,15 @@ public static void setDefault(SSLContext context) {
* may be different from the order of providers returned by
* {@link Security#getProviders() Security.getProviders()}.
*
* <p>
* In the JDK Reference implementation, a protocol can be disabled by
* adding it to the {@code jdk.tls.disabledAlgorithms} security property.
* If the specified protocol is disabled, the {@code getInstance} method
* will still return an {@code SSLContext} if there is a configured
* provider that implements the protocol. However, if the selected provider
* is the SunJSSE provider, subsequent operations that attempt to use the
* specified protocol will fail with an {@code SSLHandshakeException}.
*
* @param protocol the standard name of the requested protocol.
* See the SSLContext section in the <a href=
* "{@docRoot}/../specs/security/standard-names.html#sslcontext-algorithms">
Expand Down Expand Up @@ -199,6 +208,15 @@ public static SSLContext getInstance(String protocol)
* <p> Note that the list of registered providers may be retrieved via
* the {@link Security#getProviders() Security.getProviders()} method.
*
* @implNote
* In the JDK Reference Implementation, a protocol can be disabled by
* adding it to the {@code jdk.tls.disabledAlgorithms} security property.
* If the specified protocol is disabled, the {@code getInstance} method
* will still return an {@code SSLContext} if the specified provider
* implements the protocol. However, if the specified provider is "SunJSSE",
* subsequent operations that attempt to use the specified protocol will
* fail with an {@code SSLHandshakeException}.
*
* @param protocol the standard name of the requested protocol.
* See the SSLContext section in the <a href=
* "{@docRoot}/../specs/security/standard-names.html#sslcontext-algorithms">
Expand Down Expand Up @@ -247,6 +265,15 @@ public static SSLContext getInstance(String protocol, String provider)
* Java Security Standard Algorithm Names Specification</a>
* for information about standard protocol names.
*
* @implNote
* In the JDK Reference Implementation, a protocol can be disabled by
* adding it to the {@code jdk.tls.disabledAlgorithms} security property.
* If the specified protocol is disabled, the {@code getInstance} method
* will still return an {@code SSLContext} if the specified provider
* implements the protocol. However, if the specified provider is the
* SunJSSE provider, subsequent operations that attempt to use the
* specified protocol will fail with an {@code SSLHandshakeException}.
*
* @param provider an instance of the provider.
*
* @return the new {@code SSLContext} object
Expand Down