JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color #10317

scientificware · 2022-09-16T23:16:19Z

This is referenced in Java Bug Database as

JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color

This is tracked in JBS as

JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color

Adds the 4 and 8 digits color hex notations to CSS.java, as described in :
CSS Color Module Level 4
W3C Candidate Recommendation Snapshot, 5 July 2022
6.2 The RGB Hexadecimal Notations: #RRGGBB

Designed from : ScientificWare JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8293776: Adds CSS 4 and 8 digits hex coded Color (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/10317/head:pull/10317
$ git checkout pull/10317

Update a local copy of the PR:
$ git checkout pull/10317
$ git pull https://git.openjdk.org/jdk.git pull/10317/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10317

View PR using the GUI difftool:
$ git pr show -t 10317

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10317.diff

Webrev

Link to Webrev Comment

CSS level 4 - defines color hex code as #[2 digits Red][2 digits Green][2 digits Blue][2 digits Alpha]. With digit 0 ... f. - allows, webpage passes 3, 4, 6 or 8 digit color code. - 3 digits #[R][G][B] ........ represents #[RR][GG][BB]FF - 4 digits #[R][G][B][A] ..... represents #[RR][GG][BB][AA] - 6 digits #[RR][GG][BB] ..... represents #[RR][GG][BB]FF - 8 digits #[RR][GG][BB][AA] . represents #[RR][GG][BB][AA] Becareful ! In java.awt.Color hex #[2 digits Alpha][2 digits Red][2 digits Green][2 digits Blue] Comme cette méthode est définie dans CSS, elle doit traiter uniquement le format CSS Level 4. According notes below the current OpenJDK implementation is - 3 digits #[R][G][B] represents #[RR][GG][BB]FF - 6 digits #[R][G][B] represents #[RR][GG][BB]FF

Typo in comment.

This implementation uses a Pattern instance and parses the string argument as an unsigned integer with radix 16. - The pattern declaration and import are missing. - The parseUnsignedInt method can send a NumberFormatException, its import is missing.

java.lang.NumberFormatException is imported by default.

Updatre Copyrigth date.

Removes unnecessary integer casts.

- This modifies CSS.java hexToColor method, - by adding two hex code formats, - by treating only 2, 3, 4 and 8 digits well formated hex code, all other string returns null.

Some spaces are missing or extra.

Adds a final modifier to hex Pattern.

bridgekeeper · 2022-09-16T23:16:55Z

👋 Welcome back scientificware! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-09-16T23:19:14Z

@scientificware The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-09-16T23:21:51Z

Webrevs

Modifies the improper name of the recommendation with CSS Color Level 4. CSS Level 4 doesn't exist. CSS is a set of Modules, one of them is Color.

- Adds final modifier to hex Pattern. - corrects recommandation names CSS Level 4. - Adds missing spaces.

Adds a regression for DK-8293776 : Adds CSS 4 and 8 digits hex coded Color #13

Removes author name for JDK main-line development repository.

src/java.desktop/share/classes/javax/swing/text/html/CSS.java

Sorry. Thanks. Co-authored-by: ExE Boss <[email protected]>

Corrects typos. And applies a better digit extraction as suggested in main-line review thread.

- Corrects typos. - Applies a better digit extraction as suggested in main-line review thread. - Using charAt avoids creating temporary strings of length 1. - Also, using the %[argument_index$]conversion format specifier form allows halving the lengths of the vararg arrays. - Corrects mistake about variable declaration for parseUnsignedInt(...) method returned value. Must be int and not Integer. Hex3468DigitsColor.java : - Ajout d'un test de régression pour JDK-8293776.

aivanov-jdk · 2022-09-19T16:36:00Z

src/java.desktop/share/classes/javax/swing/text/html/CSS.java

+        if (digits.startsWith("#")) {
+            digits = digits.substring(1, Math.min(n, 9));
+            n--;
+        }


Should the method return null immediately if n < 3 || n > 8 after the if block at lines 1363-1366? It's already known the format is invalid.

I also propose adding hex.matcher(digits).matches() here to avoid running the matcher at each attempt.

In short, the next statement should be:

if (n < 3 || n == 7 || n > 8 || !hex.matcher(digits).matches()) { return null; }

The following code deals with a valid color notation.

@aivanov-jdk, I suppose that most of color notations are correct.
Adding these tests in first place has a time cost.
With &&, hex.matcher(digits).matches() is evaluated only once.
That why I separated length test from hex test. Pattern usage has a significant time cost.

@aivanov-jdk, I suppose that most of color notations are correct.

Likely, otherwise the colors wouldn't show up.

Adding these tests in first place has a time cost.

The time is rather negligible, in my opinion. Yet the code is clearer.

If you care about micro-optimisations, the n == 6 case should be the first one in the chain of if-blocks as the most common case.

With &&, hex.matcher(digits).matches() is evaluated only once. That why I separated length test from hex test.

Yes, you're absolutely right. I agree it is evaluated only once, which wasn't apparent to me from the start. Someone else may also consider it as inefficiency.

Pattern usage has a significant time cost.

Exactly. Is it even needed? The previous code did well without it.

I'm sure it's not needed, Integer.parseUnsignedInt validates the digits are valid, if not, it throws NumberFormatException. Since, as you say, it's rare that the color notation is invalid, I see no reason to avoid the exception using the pattern.

aivanov-jdk · 2022-09-19T16:41:00Z

src/java.desktop/share/classes/javax/swing/text/html/CSS.java

+        if (n == 3 && hex.matcher(digits).matches()) {
+            final char r = digits.charAt(0);
+            final char g = digits.charAt(1);
+            final char b = digits.charAt(2);
+            digits = String.format("%1$s%1$s%2$s%2$s%3$s%3$sff", r, g, b);
+        } else if (n == 4 && hex.matcher(digits).matches()) {
+            final char r = digits.charAt(0);
+            final char g = digits.charAt(1);
+            final char b = digits.charAt(2);
+            final char a = digits.charAt(3);
+            digits = String.format("%1$s%1$s%2$s%2$s%3$s%3$s%4$s%4$s", r, g, b, a);


Does it make sense to combine these two cases into one?

Suggested change

if (n == 3 && hex.matcher(digits).matches()) {

final char r = digits.charAt(0);

final char g = digits.charAt(1);

final char b = digits.charAt(2);

digits = String.format("%1$s%1$s%2$s%2$s%3$s%3$sff", r, g, b);

} else if (n == 4 && hex.matcher(digits).matches()) {

final char r = digits.charAt(0);

final char g = digits.charAt(1);

final char b = digits.charAt(2);

final char a = digits.charAt(3);

digits = String.format("%1$s%1$s%2$s%2$s%3$s%3$s%4$s%4$s", r, g, b, a);

if (n == 3 || n == 4) {

final char r = digits.charAt(0);

final char g = digits.charAt(1);

final char b = digits.charAt(2);

final char a = n == 4 ? digits.charAt(3) : 'f';

digits = String.format("%1$s%1$s%2$s%2$s%3$s%3$s%4$s%4$s", r, g, b, a);

The only difference between these two case is in a which is hard-coded as ff in the format string for n == 3.

With this change, the code is more concise but we double the number of tests ?

With this change, the code is more concise but we double the number of tests ?

For a rather rare case. I don't think it's a critical path which affects performance.

If you like, you can create a variable to store the result of n == 4 to avoid testing once again. I still don't think it's worth it.

Could we reach a conciliation with this version. ? All cases are treated in 2 or 3 tests.
It incorporates all your suggestions and my single comment about the number of tests.

if (n < 5) { if (n < 3) { return null; } else { final char r = digits.charAt(0); final char g = digits.charAt(1); final char b = digits.charAt(2); final char a = n == 4 ? digits.charAt(3) : 'f'; digits = String.format("%1$s%1$s%2$s%2$s%3$s%3$s%4$s%4$s", r, g, b, a); } } else if (n < 7) { if (n == 5) { return null; } else { digits = String.format("%sff", digits); } } else if (n != 8 ) { return null; } try { int i = Integer.parseUnsignedInt(digits, 16); return new Color((i >> 24) & 0xFF, (i >> 16) & 0xFF, (i >> 8) & 0xFF, i & 0xFF); } catch (NumberFormatException nfe) { return null; }

Some articles suggest to avoid using exceptions as flow controls. I never tested this point. That's why I introduced Patterns in this method. May I run tests in this case ? With the code below :

if (n < 5) { if (n < 3 || !hex.matcher(digits).matches()) { return null; } else { final char r = digits.charAt(0); final char g = digits.charAt(1); final char b = digits.charAt(2); final char a = n == 4 ? digits.charAt(3) : 'f'; digits = String.format("%1$s%1$s%2$s%2$s%3$s%3$s%4$s%4$s", r, g, b, a); } } else if (n < 7) { if (n == 5 || !hex.matcher(digits).matches()) { return null; } else { digits = String.format("%sff", digits); } } else if (n != 8 || !hex.matcher(digits).matches()) { return null; } try { int i = Integer.parseUnsignedInt(digits, 16); return new Color((i >> 24) & 0xFF, (i >> 16) & 0xFF, (i >> 8) & 0xFF, i & 0xFF); } catch (NumberFormatException nfe) { return null; }

I also wish to test the version with bit rotation too :

if (n < 5) { if (n < 3 || !hex.matcher(digits).matches()) { return null; } else { final char r = digits.charAt(0); final char g = digits.charAt(1); final char b = digits.charAt(2); final char a = n == 4 ? digits.charAt(3) : 'f'; digits = String.format("%1$s%1$s%2$s%2$s%3$s%3$s%4$s%4$s", r, g, b, a); } } else if (n < 7) { if (n == 5 || !hex.matcher(digits).matches()) { return null; } else { digits = String.format("%sff", digits); } } else if (n != 8 || !hex.matcher(digits).matches()) { return null; } try { return new Color(Integer.rotateRight(Integer.parseUnsignedInt(digits, 16),8), true); } catch (NumberFormatException nfe) { return null; }

Could we reach a conciliation with this version. ? All cases are treated in 2 or 3 tests.

Your new versions introduce one more condition to each case and make the code more complicated and less clear. I am for concise, clear and readable code. I am against premature optimisation, and it hasn't been proved yet that there's a performance issue.

Combining the cases of n == 3 and n == 4 avoids code duplication by introducing one more comparison to both cases. If this becomes a critical path, JIT could optimise the code.

As such, I am still for combining these two cases. If you insist, I'm okay with your original code with code duplication. Yet I'd like to eliminate the duplicate code.

Some articles suggest to avoid using exceptions as flow controls. I never tested this point. That's why I introduced Patterns in this method.

It's true, creating an exception object is a somewhat expensive operation. Yet you say, “most of color notations are correct”, therefore an incorrect color which cannot be parsed is rare, so it's an exceptional situation, it is okay to use exceptions in this case. You also say, “Pattern usage has a significant time cost,” at the same time, you introduce a small time penalty for each and every correct color.

I think the hex pattern is redundant.

I also wish to test the version with bit rotation too :

return new Color(Integer.rotateRight(Integer.parseUnsignedInt(digits, 16),8), true);

It could be not as clear, yet it works.

May I suggest wrapping the code for Color and rotateRight arguments?

return new Color( Integer.rotateRight(Integer.parseUnsignedInt(digits, 16), 8), true);

It fits better into 80-column limit. Alternatively, wrap the second parameter of rotateRight only:

return new Color(Integer.rotateRight(Integer.parseUnsignedInt(digits, 16), 8), true);

This way it's easier to see how many bits are rotated.

@aivanov-jdk My previous proposition perfectly respected all your suggestions and didn't introduce a new test.

But this discussion should be outdated if you validate this new approach. Performance results came from my repository I mentioned in the header.

The code before this PR ran in 230ms.

Our previous codes ran in 1 200ms to 1800 ms with String + formatted + %n$s usage.

They ran in 350ms to 380ms with String + formatted + %s usage.

And in 100ms to 110ms if we replace String + format with a string concatenation.

Now the code below gives the same results in 36ms and with all our expected behaviors. Since we control notation length we

can bypass some controls,

directly generate the color value,

without generate a new string,

and reject a wrong number format without generate any exception.

/** * Convert a "#FFF", "#FFFF", "#FFFFFF" or "#FFFFFFFF" hex string to a Color. * If the color specification is bad, an attempt will be made to fix it up. */ static final Color hexToColor(String digits) { // CSS Color level 4 allows webpage passes 3, 4, 6 or 8 digit color codes. // - 3 digits #[R][G][B] ........ represents #[RR][GG][BB]FF // - 4 digits #[R][G][B][A] ..... represents #[RR][GG][BB][AA] // - 6 digits #[RR][GG][BB] ..... represents #[RR][GG][BB]FF // - 8 digits #[RR][GG][BB][AA] . represents #[RR][GG][BB][AA] final byte[] iseq = digits.startsWith("#") ? iseqmap.get(Integer.valueOf(digits.length())): iseqmap.get(Integer.valueOf(-digits.length())); if (iseq == null) { // Rejects string argument with a wrong number length. return null; } // Only 3, 4, 6 and 8 digits notations. // Parses the string argument and build color value. int dv; int value = 0; for (byte i : iseq) { if ((dv = -i) != 15 && (dv = Character.digit(digits.charAt(i), 16)) < 0) { // Rejects string argument with not a valid digit in the radix-16. return null; } value = dv | value << 4; } return new Color(value, true); } // Map of Index Sequences. Index -15 means, use the default value 15. private static final Map<Integer, byte[]> iseqmap = Map.ofEntries( // Positive key, for # prefixed string, is associated with index from 1 to 8. // Negative key, for not # prefixed string, is associated with index from 0 to 7. Map.entry(Integer.valueOf(4), new byte[]{-15, -15, 1, 1, 2, 2, 3, 3}), Map.entry(Integer.valueOf(5), new byte[]{4, 4, 1, 1, 2, 2, 3, 3}), Map.entry(Integer.valueOf(7), new byte[]{-15, -15, 1, 2, 3, 4, 5, 6}), Map.entry(Integer.valueOf(9), new byte[]{7, 8, 1, 2, 3, 4, 6, 6}), Map.entry(Integer.valueOf(-3), new byte[]{-15, -15, 0, 0, 1, 1, 2, 2}), Map.entry(Integer.valueOf(-4), new byte[]{3, 3, 0, 0, 1, 1, 2, 2}), Map.entry(Integer.valueOf(-6), new byte[]{-15, -15, 0, 1, 2, 3, 4, 5}), Map.entry(Integer.valueOf(-8), new byte[]{6, 7, 0, 1, 2, 3, 4, 5}) );

~~This method is too strict ! Test with "#1fe56980 ", "#1fe56980 ". Made changes to be able to parse this kind of string.~~
~~Should I declare idseq as final for the same reasons a, b, c were declared final in the previous version.~~

src/java.desktop/share/classes/javax/swing/text/html/CSS.java

test/jdk/javax/swing/text/html/CSS/Hex3468DigitsColor.java

Removes Classpath exception.

Suggested change, not to use `l` as an identifier because it could be confused with `1`. This part of code could change and be replaced by bits right rotation after performance tests.

Removes individual color tests and only compares the RGB value.

test/jdk/javax/swing/text/html/CSS/Hex3468DigitsColor.java

bridgekeeper · 2023-01-12T00:36:49Z

@scientificware This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

scientificware · 2023-01-12T12:10:03Z

Still waiting a review.

L'utilisation de la classe Patter n'est plus d'actualité.

Updates copyright date to 2023.

SWinxy · 2023-02-23T18:42:36Z

I don't know if I like the use of Maps. I think I would prefer doing it via an enhanced switch. I've written a sketch of what I would write. Untested and probably very wrong, but I like it.

static Color hexToColor(String digits) {
    if (digits.startsWith("#")) {
        digits = digits.substring(1);
    }

    try {
        int a = Integer.parseInt(digits, 16);

        return switch (digits.length()) {
            case 3 -> new Color((a & 0xF00) << 24 | (a & 0xF0) << 16 | (a & 0xF) << 8 | 0xFF);
            case 4 -> new Color((a & 0xF000) << 24 | (a & 0xF00) << 16 | (a & 0xF0) << 8 | (a & 0xF));
            case 6 -> new Color((a & 0xFF0000) << 24 | (a & 0xFF00) << 16 | (a & 0xFF) << 8 | 0xFF);
            case 8 -> new Color(a);
            default -> null;
        }
    } catch (NumberFormatException e) {
        return null;
    }
}

I don't like when PRs languish. It sucks.

prrace · 2023-02-28T01:04:34Z

As noted there, this PR likely needs to be withdrawn and absorbed into #9825

src/java.desktop/share/classes/javax/swing/text/html/CSS.java

bridgekeeper · 2023-03-28T21:16:04Z

@scientificware This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

scientificware · 2023-03-29T12:20:26Z

Delay due to the reorganization of my contribution schedule caused by new requests.

bridgekeeper · 2023-04-26T19:41:17Z

@scientificware This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

scientificware · 2023-04-26T19:44:35Z

Delay due to the reorganization of my contribution schedule caused by new requests.

bridgekeeper · 2023-05-25T02:16:18Z

@scientificware This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

scientificware · 2023-05-25T05:58:52Z

Delay due to the reorganization of my contribution schedule caused by new requests.

bridgekeeper · 2023-06-22T11:24:50Z

@scientificware This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2023-07-20T15:59:12Z

@scientificware This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

scientificware · 2023-07-30T12:55:16Z

/open

openjdk · 2023-07-30T12:56:53Z

@scientificware This pull request is now open

…ignments into separate line. Merge master # Conflicts: # src/java.desktop/share/classes/javax/swing/text/html/CSS.java

CSS.java : Removes assigning values inside the if-condition Extracts the assignments into separate line. Hex3468DigitsColor.java : Adds a message to result in case of failure only

openjdk · 2023-08-11T15:27:15Z

⚠️ @scientificware This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

…_8_digits_hex_coded_color

prrace · 2023-08-17T18:02:01Z

Back in Feb I wrote

As noted there, this PR likely needs to be withdrawn and absorbed into #9825

Nothing has changed on that front, so I don't know why you re-opened this.

scientificware · 2023-08-17T18:48:23Z

@prrace Before withdraw it, I wanted to push all @aivanov-jdk's requested changes in this branch.

scientificware added 9 commits September 10, 2022 14:52

Typo.

04f2d68

Typo in comment.

Adds missing import and declaration.

fe75e26

This implementation uses a Pattern instance and parses the string argument as an unsigned integer with radix 16. - The pattern declaration and import are missing. - The parseUnsignedInt method can send a NumberFormatException, its import is missing.

Remove NumberFormatException

146bba4

java.lang.NumberFormatException is imported by default.

Update Copyrigth.

d1301f3

Updatre Copyrigth date.

Removes int cast.

7d7f49f

Removes unnecessary integer casts.

- This modifies the CSS.java Copyright date.

dd02813

- This modifies CSS.java hexToColor method, - by adding two hex code formats, - by treating only 2, 3, 4 and 8 digits well formated hex code, all other string returns null.

Adds or removes spaces.

0ebf174

Some spaces are missing or extra.

Adds final modifier.

7a99e7c

Adds a final modifier to hex Pattern.

scientificware mentioned this pull request Sep 16, 2022

JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color scientificware/jdk#13

Open

openjdk bot added the rfr Pull request is ready for review label Sep 16, 2022

openjdk bot added the client [email protected] label Sep 16, 2022

scientificware added 2 commits September 17, 2022 02:18

Improper Name in comments

5b36517

Modifies the improper name of the recommendation with CSS Color Level 4. CSS Level 4 doesn't exist. CSS is a set of Modules, one of them is Color.

CSS.java

1724cdf

- Adds final modifier to hex Pattern. - corrects recommandation names CSS Level 4. - Adds missing spaces.

scientificware mentioned this pull request Sep 17, 2022

JDK-8292276 : Add named colors from CSS Color Module Level 4 scientificware/jdk#12

Open

scientificware added 2 commits September 17, 2022 18:23

Adds regression test.

93dc0bb

Adds a regression for DK-8293776 : Adds CSS 4 and 8 digits hex coded Color #13

Removes author name.

24040cf

Removes author name for JDK main-line development repository.

ExE-Boss reviewed Sep 17, 2022

View reviewed changes

src/java.desktop/share/classes/javax/swing/text/html/CSS.java Outdated Show resolved Hide resolved

src/java.desktop/share/classes/javax/swing/text/html/CSS.java Outdated Show resolved Hide resolved

scientificware and others added 3 commits September 18, 2022 09:08

Update src/java.desktop/share/classes/javax/swing/text/html/CSS.java

5970980

Sorry. Thanks. Co-authored-by: ExE Boss <[email protected]>

Corrects typos and digit extraction.

e6454c1

Corrects typos. And applies a better digit extraction as suggested in main-line review thread.

aivanov-jdk suggested changes Sep 19, 2022

View reviewed changes

Corrects Licence Header.

478f285

Removes Classpath exception.

scientificware mentioned this pull request Sep 21, 2022

JDK-8294090 : Aligns the CSS <rgb()> and <rgba()> function behaviours scientificware/jdk#16

Open

2 tasks

scientificware added 2 commits September 23, 2022 05:09

Renames an identifier.

767c87c

Suggested change, not to use `l` as an identifier because it could be confused with `1`. This part of code could change and be replaced by bits right rotation after performance tests.

Simplifications of the test.

a95d282

Removes individual color tests and only compares the RGB value.

aivanov-jdk reviewed Sep 26, 2022

View reviewed changes

test/jdk/javax/swing/text/html/CSS/Hex3468DigitsColor.java Outdated Show resolved Hide resolved

Suppression d'un import non utilisé.

eba37e9

L'utilisation de la classe Patter n'est plus d'actualité.

scientificware requested a review from aivanov-jdk February 5, 2023 09:49

scientificware added 2 commits February 5, 2023 10:50

aivanov-jdk suggested changes Feb 28, 2023

View reviewed changes

src/java.desktop/share/classes/javax/swing/text/html/CSS.java Show resolved Hide resolved

bridgekeeper bot closed this Jul 20, 2023

openjdk bot reopened this Jul 30, 2023

scientificware added 3 commits August 11, 2023 14:43

Removes assigning values inside the if-condition and extracts the ass…

ed69596

…ignments into separate line. Merge master # Conflicts: # src/java.desktop/share/classes/javax/swing/text/html/CSS.java

Merge master

06409e6

Merge branch 'master'

d72cb9f

CSS.java : Removes assigning values inside the if-condition Extracts the assignments into separate line. Hex3468DigitsColor.java : Adds a message to result in case of failure only

scientificware mentioned this pull request Aug 12, 2022

JDK-8265909 : build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home #3626 scientificware/jdk#2

Open

Merge branch 'openjdk:master' into scientificware-patch-003-CSS-add_4…

0dbd8f0

…_8_digits_hex_coded_color

scientificware closed this Aug 17, 2023

JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color #10317

JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color #10317

Uh oh!

Conversation

scientificware commented Sep 16, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Sep 16, 2022

Uh oh!

openjdk bot commented Sep 16, 2022

Uh oh!

mlbridge bot commented Sep 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

scientificware Sep 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

scientificware Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bridgekeeper bot commented Jan 12, 2023

Uh oh!

scientificware commented Jan 12, 2023

Uh oh!

SWinxy commented Feb 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prrace commented Feb 28, 2023

Uh oh!

Uh oh!

bridgekeeper bot commented Mar 28, 2023

Uh oh!

scientificware commented Mar 29, 2023

Uh oh!

bridgekeeper bot commented Apr 26, 2023

Uh oh!

scientificware commented Apr 26, 2023

Uh oh!

bridgekeeper bot commented May 25, 2023

Uh oh!

scientificware commented May 25, 2023

Uh oh!

bridgekeeper bot commented Jun 22, 2023

Uh oh!

bridgekeeper bot commented Jul 20, 2023

Uh oh!

scientificware commented Jul 30, 2023

Uh oh!

openjdk bot commented Jul 30, 2023

Uh oh!

openjdk bot commented Aug 11, 2023

scientificware commented Sep 16, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 16, 2022 •

edited

Loading

scientificware Sep 27, 2022 •

edited

Loading

scientificware Sep 28, 2022 •

edited

Loading

SWinxy commented Feb 23, 2023 •

edited

Loading