-
Couldn't load subscription status.
- Fork 60
feat(java-sdk): add support for write conflict settings #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughAdds conflict-handling options to Java client write/delete requests by threading onDuplicate (writes) and onMissing (deletes) through client methods and builders. Introduces new option fields in configuration classes, updates request construction, and extends tests. Documents usage in README. Bumps OpenFGA Docker tag to v1.10.2. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant App as Application
participant Client as OpenFgaClient
participant Builder as Request Builders
participant API as OpenFGA API
App->>Client: write(tupleKeys, options{onDuplicate, onMissing})
Client->>Builder: asWriteRequestWrites(tupleKeys, onDuplicate)
note over Builder: Conditionally set on_duplicate if provided
Builder-->>Client: WriteRequest.writes
Client->>Builder: asWriteRequestDeletes(tupleKeysToDelete, onMissing)
note over Builder: Conditionally set on_missing if provided
Builder-->>Client: WriteRequest.deletes
Client->>API: POST /stores/{id}/write {writes, deletes, on_duplicate/on_missing embedded}
API-->>Client: 200 OK (transaction/write response)
Client-->>App: Result
sequenceDiagram
autonumber
participant App as Application
participant Client as OpenFgaClient
participant Builder as Request Builders
participant API as OpenFGA API
App->>Client: deleteTuples(keys, options{onMissing})
Client->>Builder: asWriteRequestDeletes(keys, onMissing)
Builder-->>Client: WriteRequest
Client->>API: POST /write {deletes with on_missing}
API-->>Client: 200 OK
Client-->>App: Result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Generator PR for openfga/java-sdk#234
Review Checklist
mainSummary by CodeRabbit