release(java-sdk): release v0.9.0 #600
Conversation
WalkthroughUpdates Java client templates and config for v0.9.0: changelog entry and notes, version bump, and README retry sample reflecting API changes. Introduces a new public getter for Retry-After in FgaError and changes ClientConfiguration.minimumRetryDelay to accept java.time.Duration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (6)
config/clients/java/template/README_retries.mustache (5)
25-31: Add missing imports for Duration, FgaError, and ExecutionException; remove unused imports.The snippet uses Duration and FgaError, and catches ExecutionException, but the imports are missing. Also, ObjectMapper and HttpClient are unused in this example.
Apply this diff to fix the imports:
-import com.fasterxml.jackson.databind.ObjectMapper; +import java.time.Duration; +import java.util.concurrent.ExecutionException; import dev.openfga.sdk.api.client.OpenFgaClient; import dev.openfga.sdk.api.configuration.ClientConfiguration; -import java.net.http.HttpClient; +import dev.openfga.sdk.errors.FgaError;
57-60: Avoid implying the Retry-After value is always in seconds.RFC 9110 allows both delta-seconds and HTTP-date formats. The example should not add "seconds" unconditionally.
Apply this diff to clarify the output:
- System.out.println("Server requested retry after: " + retryAfter + " seconds"); + System.out.println("Server requested Retry-After: " + retryAfter);
25-29: Optional: keep the snippet minimal by removing unused imports.If you prefer brevity in examples, drop imports not used in the snippet.
Apply this diff to remove unused imports (if you don’t plan to extend the sample):
-import com.fasterxml.jackson.databind.ObjectMapper; -import java.net.http.HttpClient;
20-23: Consider noting the Duration-based minimumRetryDelay in the Breaking Changes list.You call out getRetryAfterHeader, but not the switch to Duration for minimumRetryDelay here (it is shown in the code). Adding it improves discoverability.
Would you like me to propose wording to add a one-liner about “minimumRetryDelay now accepts java.time.Duration” in this section?
1-1: Optional: clarify “maximum allowable: 15 retries” applies to configuration.A short parenthetical like “(configured via maxRetries, capped at 15)” can reduce ambiguity.
config/clients/java/CHANGELOG.md.mustache (1)
11-12: Deduplicate “Retry-After header value exposed” bullets.These two bullets convey the same change.
Apply this diff to merge into a single line:
-- RFC 9110 compliant `Retry-After` header support with exponential backoff and jitter -- `Retry-After` header value exposed in error objects for better observability -- `FgaError` now exposes `Retry-After` header value via `getRetryAfterHeader()` method +- RFC 9110 compliant `Retry-After` header support with exponential backoff and jitter +- `FgaError` now exposes the `Retry-After` header via `getRetryAfterHeader()` for better observability
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
config/clients/java/CHANGELOG.md.mustache(1 hunks)config/clients/java/config.overrides.json(1 hunks)config/clients/java/template/README_retries.mustache(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-and-test-java-sdk
- GitHub Check: build-and-test-go-sdk
🔇 Additional comments (3)
config/clients/java/config.overrides.json (1)
6-6: All Java client templates are up to date
No occurrences of “0.8.3” remain inconfig/clients/java/(excludingCHANGELOG.md.mustache). The bump to 0.9.0 aligns with the CHANGELOG and README updates.config/clients/java/template/README_retries.mustache (1)
37-37: Good API example update to Duration.Using Duration for minimumRetryDelay aligns with the new API and avoids int millis ambiguity.
config/clients/java/CHANGELOG.md.mustache (1)
7-7: Release date and compare link look correct.v0.9.0 dated 2025-08-15 with compare v0.8.3...v0.9.0 matches the version bump.
github-merge-queue
bot
removed this pull request from the merge queue due to Branch Protection failures
release v0.9.0
openfga/java-sdk#207
Summary by CodeRabbit