Skip to content

Conversation

@evansims
Copy link
Contributor

Description

This PR updates the urllib3 dependency definition to loosen installation restrictions.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@evansims evansims added the dependencies Pull requests that update a dependency file label Apr 11, 2025
@evansims evansims force-pushed the chore/update-dependencies branch from 0f6f953 to b24506a Compare April 11, 2025 20:57
@evansims evansims marked this pull request as ready for review April 11, 2025 20:58
@evansims evansims requested a review from a team as a code owner April 11, 2025 20:58
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.45%. Comparing base (d4e31a2) to head (b24506a).

❌ Your project status has failed because the head coverage (70.45%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   70.45%   70.45%           
=======================================
  Files         134      134           
  Lines       10806    10806           
=======================================
  Hits         7613     7613           
  Misses       3193     3193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rhamzeh
Copy link
Member

rhamzeh commented Apr 11, 2025

Moving to draft so that we don't merge before given the all clear that this fixes the issue

@rhamzeh rhamzeh marked this pull request as draft April 11, 2025 21:04
@rhamzeh rhamzeh marked this pull request as ready for review April 14, 2025 21:56
@rhamzeh rhamzeh added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit a5425ac Apr 14, 2025
24 checks passed
@rhamzeh rhamzeh deleted the chore/update-dependencies branch April 14, 2025 21:57
@rhamzeh rhamzeh mentioned this pull request Apr 30, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants