Skip to content

Conversation

@evansims
Copy link
Contributor

Description

Thanks to @GMorris-professional for contributing these changes in openfga/sdk-generator#516

ListRelations now throws the first error that occurs during one of the checks instead of swallowing it.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@evansims evansims added the bug Something isn't working label Mar 26, 2025
@evansims evansims force-pushed the fix/listrelations-should-not-swallow-errors branch 4 times, most recently from b961c87 to 96ebb73 Compare March 26, 2025 16:58
@evansims evansims marked this pull request as ready for review March 26, 2025 16:58
@evansims evansims requested a review from a team as a code owner March 26, 2025 16:58
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.48%. Comparing base (d4e31a2) to head (e4715de).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   70.45%   70.48%   +0.03%     
==========================================
  Files         134      134              
  Lines       10806    10818      +12     
==========================================
+ Hits         7613     7625      +12     
  Misses       3193     3193              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rhamzeh rhamzeh force-pushed the fix/listrelations-should-not-swallow-errors branch from 854001c to e4715de Compare April 11, 2025 21:10
@evansims evansims added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit 3a72f6e Apr 11, 2025
21 of 23 checks passed
@evansims evansims deleted the fix/listrelations-should-not-swallow-errors branch April 11, 2025 21:13
@rhamzeh rhamzeh mentioned this pull request Apr 30, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants