-
Notifications
You must be signed in to change notification settings - Fork 22
chore: Added a top-level Makefile in js-sdk to simplify running tests and li… #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughA new Makefile is added to define common project automation targets for installation, building, testing, linting, auditing, and cleanup operations. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for your PR @Abishek-Newar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abishek-Newar Could you possibly add one more which would help to quickly do a local sanity of the checks in the generator https://github.com/openfga/sdk-generator/blob/d15c31eff4abeda628a03e7b82da593d2ea53b15/Makefile#L66
so essentially test audit run-lint together
- Added check target that runs lint, test, and audit - Updated all target to include the new check target - Updated help text to reflect changes Closes openfga#272
|
@SoulPancake Done with changes that you have suggested , is there any more changes that i should make |
more clean make all command Co-authored-by: Raghd Hamzeh <[email protected]>
more clean make check command Co-authored-by: Raghd Hamzeh <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 88.88% 88.88%
=======================================
Files 23 23
Lines 1260 1260
Branches 230 230
=======================================
Hits 1120 1120
Misses 84 84
Partials 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, Thanks
Description
Added a standardized Makefile would make it much easier to test and lint the code locally with simple, consistent commands which would make it easy for contrubuters.
What problem is being solved?
How is it being solved?
What changes are made to solve it?
Added a Makefile to it
References
Closes #272
Review Checklist
mainSummary by CodeRabbit