Skip to content

Conversation

@rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Jul 1, 2025

Description

References

Source: openfga/sdk-generator#566
Closes: #178

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Refactor
    • Adjusted visibility of a field in the client to improve accessibility for users.
    • Added a new method to enhance access to underlying API functionality.

@rhamzeh rhamzeh requested a review from a team as a code owner July 1, 2025 19:48
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 1, 2025

Walkthrough

A new public method getApi() was added to the OpenFgaClient class, providing access to the underlying OpenFgaApi instance. No other code or logic was modified.

Changes

File Change Summary
src/main/java/dev/openfga/sdk/api/client/OpenFgaClient.java Added public OpenFgaApi getApi() method

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4394ca0 and 6028a98.

📒 Files selected for processing (1)
  • src/main/java/dev/openfga/sdk/api/client/OpenFgaClient.java (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/main/java/dev/openfga/sdk/api/client/OpenFgaClient.java
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: Test and Build OpenFGA (21)
  • GitHub Check: Test and Build OpenFGA (17)
  • GitHub Check: Test and Build OpenFGA (11)
  • GitHub Check: Analyze (java)
  • GitHub Check: Test and Build OpenFGA (17)
  • GitHub Check: Test and Build OpenFGA (11)
  • GitHub Check: Test and Build OpenFGA (21)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.48%. Comparing base (71ddedc) to head (6028a98).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...java/dev/openfga/sdk/api/client/OpenFgaClient.java 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (34.48%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #176      +/-   ##
============================================
+ Coverage     33.42%   34.48%   +1.05%     
- Complexity      994     1032      +38     
============================================
  Files           182      182              
  Lines          6878     7003     +125     
  Branches        772      801      +29     
============================================
+ Hits           2299     2415     +116     
- Misses         4476     4477       +1     
- Partials        103      111       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jimmyjames jimmyjames enabled auto-merge July 1, 2025 20:10
@jimmyjames jimmyjames disabled auto-merge July 1, 2025 20:10
@rhamzeh rhamzeh force-pushed the feat/make-inner-api-public branch from 4394ca0 to 6028a98 Compare July 1, 2025 20:25
@rhamzeh rhamzeh added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit c9163dd Jul 1, 2025
24 checks passed
@rhamzeh rhamzeh deleted the feat/make-inner-api-public branch July 1, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a way to access the inner client

4 participants