Skip to content

Conversation

@saikiran2603
Copy link
Contributor

@saikiran2603 saikiran2603 commented Apr 1, 2021

Signed-off-by: saikiran [email protected]

Tox config is not in the directory from where tox command is executed, moved WORKDIR change which was happening before test to after , this ensures tox executes from inside the function folder.

Description

moved WORKDIR command after the test execution , modified copy and chown command to execute properly from new WORKDIR

Motivation and Context

helps fix issue #44

  • I have raised an issue to propose this change (required)
  • My issue has received approval from the maintainers or lead with the design/approved label

How Has This Been Tested?

tested with creating new function and executing faas build.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@derek derek bot added the new-contributor label Apr 1, 2021
Copy link
Member

@LucasRoesler LucasRoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the templates are now in sync

@LucasRoesler
Copy link
Member

@alexellis this is :shipit:

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you both

@alexellis alexellis merged commit 12db680 into openfaas:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants