Skip to content

Conversation

@brian-smith-tcril
Copy link
Contributor

Description

Include a description of your changes here, along with a link to any relevant Jira tickets and/or GitHub issues.

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@arbrandes arbrandes merged commit d747478 into openedx:master May 10, 2024
@awais-ansari
Copy link
Contributor

The Discussion Forum is not working on stage. API calls are working fine. There is no code error in the console. We suspect that this PR might be a cause behind this issue. So, I'm reverting this PR.

Screenshot 2024-05-13 at 6 02 08 PM

@awais-ansari
Copy link
Contributor

Discussion is working fine now after reverting this PR.

@brian-smith-tcril
Copy link
Contributor Author

brian-smith-tcril commented May 13, 2024

@awais-ansari is stage using a custom footer component?

edit: see below comment for updated plan

My assumption is that stage is using https://github.com/edx/frontend-component-footer-edx, in which case FooterSlot is not being provided by that package. There are 2 ways to go about solving this:

@brian-smith-tcril
Copy link
Contributor Author

We're working on a new pattern that will allow the footerslot to be shared while not requiring any updates to forked footers.

@awais-ansari
Copy link
Contributor

@brian-smith-tcril good to hear that but we are not using any custom footer component. Today the same issue occurred on account MFE. The Stage was broken for account MFE. We need to update the testing approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants