Feat/dynamic layers v2 #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bob-voorhoede
commented
Aug 11, 2020
SiggyF
reviewed
Aug 17, 2020
CindyvdVries
approved these changes
Oct 8, 2020
Contributor
CindyvdVries
left a comment
CindyvdVries
left a comment
There was a problem hiding this comment.
Looks good! thanks!
| import { action } from '@storybook/addon-actions'; | ||
| import { withKnobs, text, number, boolean, array, select, color, date, button } from '@storybook/addon-knobs'; | ||
| import { linkTo } from '@storybook/addon-links'; | ||
| import { storiesOf } from '@storybook/vue'; |
Contributor
There was a problem hiding this comment.
more general thing, with or without ; ?
| return { | ||
| template: dynamicLayersTemplate, | ||
| data: () => ({ | ||
| style: 'mapbox://styles/global-data-viewer/cjtss3jfb05w71fmra13u4qqm', |
Contributor
There was a problem hiding this comment.
this is from a specific project? is it useful to relate that to this general package, even if only in a story?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially an improved version of #14.
It has the same functionality:
"Currently it is not possible to add layers dynamically, because deferredMountedTo only gets called on initialisation of the map. In this PR the (re)rendering is handled internaly in the v-mapbox-layer component, by either calling mounted or deferredMountedTo. When the layer is loaded later than the map is initialised, it uses mounted, otherwise deferredMountedTo."
This PR also comes with a storybook story.