Skip to content

LayerListControls item not found fix #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

LayerListControls item not found fix #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/vue-components/lib/components/LayerListControls/LayerListControls.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
</template>

<script>
import { watch, ref, toRefs, computed } from '@vue/composition-api'
import { watch, ref, toRefs, computed, onMounted } from '@vue/composition-api'
import addIndex from './add-index'
import findInTree from './find-in-tree'
import addParentIdToLayers from './add-parent-id-to-layers'
Expand All @@ -58,6 +58,10 @@ export default {
const { activeLegend, setActiveLegend } = useLegend(selectedIds)
const { onSortingChange } = useSortable(layers, root, openItems)

onMounted(() => {
Copy link
Collaborator

@bob-voorhoede bob-voorhoede Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're delegating responsibility for clearing state (the ref in useSelected) to the Vue component. Is this really desired, or should useSelected() return a 'scoped' piece of state, so that every LayerListControls component has its own selectedIds that is strictly private to that instance of the component?

setSelectedIds([])
})

const sortedSelectedLayers = computed(() => {
const withIndex = addIndex(layers.value)
return selectedIds.value
Expand Down