This repository was archived by the owner on Mar 21, 2025. It is now read-only.
build-and-push-images use linux/amd64 for typescript #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsauter
approved these changes
Jan 12, 2022
Member
michaelsauter
left a comment
michaelsauter
left a comment
There was a problem hiding this comment.
LGTM.
It would be nice if we wouldn't need to list all images but I guess hardcoding a platform in the build-and-push-images.sh for Node/TypeScript isn't less brittle ...
Member
Author
|
Addressed shellcheck warnings but used exception as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support building images on an M1.
The typescript image currently uses chrome for cypress.
Until there is a use case which allows verification of using chromium stay with chrome so force platform linux/amd64 for the image.
Fixes #360
Tasks:
docs/designdirectory or not applicabledocsdirectory or not applicablemake test) or not applicable